Skip to content

Commit 0d563d5

Browse files
test(kernel): trim redundant HTTP/2 assertions
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
1 parent b655703 commit 0d563d5

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

‎tests/unit/kernel/connectionOptions.test.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,10 @@ describe('Kernel HTTP/2 configuration', () => {
3535
});
3636
}
3737

38-
for (const enableHttp2 of ['false', 0, 1, null]) {
39-
it(`rejects enableHttp2=${JSON.stringify(enableHttp2)}`, () => {
40-
const options = { ...PAT, enableHttp2 } as unknown as ConnectionOptions;
41-
expect(() => buildKernelConnectionOptions(options)).to.throw(HiveDriverError, 'enableHttp2');
42-
});
43-
}
38+
it('rejects a non-boolean enableHttp2', () => {
39+
const options = { ...PAT, enableHttp2: 'false' } as unknown as ConnectionOptions;
40+
expect(() => buildKernelConnectionOptions(options)).to.throw(HiveDriverError, 'enableHttp2');
41+
});
4442
});
4543

4644
// Cast helper: the kernel connection-tuning/TLS options live on the internal

‎tests/unit/kernel/execution.test.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,6 @@ describe('KernelBackend', () => {
544544
path: '/sql/1.0/warehouses/xyz',
545545
token: 'dapi-token',
546546
enableGeoSpatialSupport: false,
547-
enableHttp2: false,
548547
} as ConnectionOptions);
549548

550549
await backend.openSession({});
@@ -563,7 +562,6 @@ describe('KernelBackend', () => {
563562
token: 'dapi-token',
564563
intervalsAsString: true,
565564
enableGeoSpatialSupport: false,
566-
enableHttp2: false,
567565
});
568566
});
569567

0 commit comments

Comments
 (0)