Skip to content

Commit f417907

Browse files
learn: retrospective learnings (#624)
Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com> Co-authored-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent bd8cb80 commit f417907

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Learning journal 2026-11-18
2+
3+
### 2026-11-18: Bot workflow and CI — GitHub Actions dot dereference accepts hyphenated property names
4+
**Context:** In PR #620 the seeded lesson L-0060 said hyphenated workflow_dispatch inputs need bracket notation. In PR #621 it was corrected: GitHub Actions expressions allow `-` in property names under dot dereference, so the repo's own `${{ inputs.window-hours }}` is valid. The archived #499 claim that it parses as subtraction was wrong.
5+
**Rule:** Do not flag or rewrite `${{ inputs.some-name }}` as a subtraction bug, because GitHub Actions expressions allow hyphens in dot-dereferenced property names.
6+
7+
### 2026-11-18: Retrospective / lessons — Check a lesson against nearby code and docs before promoting it to a standing rule
8+
**Context:** In PR #620, archived log entries were distilled into lessons.md, which is now the only learning text injected into both bots' prompts. A reviewer found that L-0060 contradicted the workflow file right next to it and was unsupported, and PR #621 cut it back to the verified part only.
9+
**Rule:** Before promoting an archived or journal observation into lessons.md, check it against the current code and the official docs, and keep only the verified part, because injected lessons drive bot edits and findings.
10+

‎.claude/knowledge/lessons.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Lessons
22

3-
<!-- distilled-through: none -->
3+
<!-- distilled-through: 2026-11-18 -->
44

55
## Configuration and authentication
66
- L-0001 (3×, #457): Trace option support through DBSQLClient, auth adapters and each transport. Type declarations and class comments do not establish forwarding; shared preparation can precede backend-specific filtering.
@@ -77,3 +77,4 @@
7777
- L-0064 (1×, #566): Scrub JFrog and OIDC request credentials inside the model-driven step; modifying GITHUB_ENV does not unset its inherited environment.
7878
- L-0065 (1×, #566): Build after installs that omit prepare so generated lib/version.ts exists before tests/type checks.
7979
- L-0066 (1×, #566 #562): Serialize branch-editing bot flows with one per-PR concurrency group and restore dependency-setup lockfile rewrites before agent edits.
80+
- L-0067 (1×, #621 #620): GitHub Actions expressions allow hyphens in dot-dereferenced names; do not flag or rewrite `${{ inputs.some-name }}` as subtraction.

0 commit comments

Comments
 (0)