fix(device): keep iOS 17, iPhone 16 Pro and iPhone 16 Pro Max in the … (#290)

fix(device): keep iOS 17, iPhone 16 Pro and iPhone 16 Pro Max in the help text

iOS 17, iphone-16-pro and iphone-16-pro-max stay supported until a later
removal, so the --ios-device and --ios-version help text lists them
again. iphone-15, iphone-16-plus and ipad-pro-6th-gen stay removed, and
the default mirror stays iphone-16 / iOS 26.

The validation test fixture gives iphone-14 iOS 17 and 18 again, as the
API does; a device-only iphone-14 request still fails because iOS 26 is
not offered, and its message now lists 17, 18.

Author: finalerock44

src/types/domain/device.types.ts

@@ -18,6 +18,8 @@ export enum EiOSDevices {
   'ipad-pro-m5-13' = 'ipad-pro-m5-13',
   'iphone-14' = 'iphone-14',
   'iphone-16' = 'iphone-16',
+  'iphone-16-pro' = 'iphone-16-pro',
+  'iphone-16-pro-max' = 'iphone-16-pro-max',
   'iphone-17' = 'iphone-17',
   'iphone-18-pro' = 'iphone-18-pro',
   'iphone-18-pro-max' = 'iphone-18-pro-max',
@@ -39,6 +41,7 @@ export enum EAndroidDevices {
 
 export enum EiOSVersions {
   'eighteen' = '18',
+  'seventeen' = '17',
   'twentySeven' = '27',
   'twentySix' = '26',
 }

test/unit/device-validation.service.test.ts

@@ -11,7 +11,7 @@ import type { CompatibilityData } from '../../src/utils/compatibility.js';
  */
 const compat: CompatibilityData = {
   ios: {
-    'iphone-14': ['18'],
+    'iphone-14': ['17', '18'],
     'iphone-16': ['18', '26', '27'],
     'iphone-17': ['26', '27'],
     'iphone-19': ['28'],
@@ -117,7 +117,7 @@ describe('DeviceValidationService', () => {
 
     it('rejects an unsupported explicit pair with the device\'s versions', () => {
       expect(() => ios('27', 'iphone-14')).to.throw(
-        /^iphone-14 only supports these iOS versions: 18$/,
+        /^iphone-14 only supports these iOS versions: 17, 18$/,
       );
       expect(() => android('34', 'pixel-10')).to.throw(
         /^pixel-10 only supports these Android API levels: 36, 37$/,
@@ -136,7 +136,7 @@ describe('DeviceValidationService', () => {
   describe('requests that rely on a default', () => {
     it('tells a device-only iOS request to pass the version explicitly', () => {
       expect(() => ios(undefined, 'iphone-14')).to.throw(
-        'iphone-14 only supports these iOS versions: 18. No iOS version was given, so the default (26) was checked: pass one of those explicitly with --ios-version',
+        'iphone-14 only supports these iOS versions: 17, 18. No iOS version was given, so the default (26) was checked: pass one of those explicitly with --ios-version',
       );
     });