From 2e3c95dda75948b34a19491f6e9df0d26fafe613 Mon Sep 17 00:00:00 2001 From: jamesconwaydev <148910373+jamesconwaydev@users.noreply.github.com> Date: Fri, 6 Nov 2026 11:46:53 -0700 Subject: [PATCH 1/2] fix(admin): stop setup_repo.sh turning code-owner review back off --- scripts/admin/setup_repo.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/admin/setup_repo.sh b/scripts/admin/setup_repo.sh index b72a126..db436af 100755 --- a/scripts/admin/setup_repo.sh +++ b/scripts/admin/setup_repo.sh @@ -48,8 +48,8 @@ RULESET=$(cat <<'J' "parameters": { "required_approving_review_count": 1, "dismiss_stale_reviews_on_push": true, - "require_code_owner_review": false, - "require_last_push_approval": false, + "require_code_owner_review": true, + "require_last_push_approval": true, "required_review_thread_resolution": false, "require_extra_approval_for_unattributed_changes": true } From 4bb24f372747efe82461c03751ac860eec59103b Mon Sep 17 00:00:00 2001 From: jamesconwaydev <148910373+jamesconwaydev@users.noreply.github.com> Date: Fri, 6 Nov 2026 11:47:28 -0700 Subject: [PATCH 2/2] fix(admin): read ruleset ids without mapfile so macOS bash 3.2 runs it --- scripts/admin/setup_repo.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/admin/setup_repo.sh b/scripts/admin/setup_repo.sh index db436af..f8c432a 100755 --- a/scripts/admin/setup_repo.sh +++ b/scripts/admin/setup_repo.sh @@ -106,7 +106,11 @@ J upsert_ruleset() { local ids # This repo's own rulesets only: an org ruleset with the same name can't be updated from here. - mapfile -t ids < <(gh api --paginate "repos/$REPO/rulesets?includes_parents=false" \ + # A read loop, not mapfile: macOS still ships bash 3.2. + ids=() + while IFS= read -r id; do + [ -n "$id" ] && ids+=("$id") + done < <(gh api --paginate "repos/$REPO/rulesets?includes_parents=false" \ --jq ".[] | select(.name==\"$1\") | .id" | sort -n) if [ "${#ids[@]}" -gt 1 ]; then # Deleting a ruleset is a call to make by hand, so update the oldest and say which others exist.