From d82ed4554eb0143b603d0e59c0b52ee8baf9775c Mon Sep 17 00:00:00 2001 From: Yurii214 <216080096+Yurii214@users.noreply.github.com> Date: Sun, 24 May 2026 14:38:40 +0000 Subject: [PATCH] fix(queue): evict failed PR_FILES jobs so retries are not blocked Closes #124 Mirror PR_METADATA (#118): use removeOnFail: true on PR_FILES enqueue sites so a failed fetch-pr-files job does not retain the deterministic jobId and block later refreshes for the same SHA tuple. --- packages/das/src/queue/fetch.processor.ts | 4 +++- packages/das/src/webhook/handlers/pull-request.handler.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/das/src/queue/fetch.processor.ts b/packages/das/src/queue/fetch.processor.ts index 08e1e6d..7b59314 100644 --- a/packages/das/src/queue/fetch.processor.ts +++ b/packages/das/src/queue/fetch.processor.ts @@ -245,7 +245,9 @@ export class FetchProcessor extends WorkerHost { expectedBaseSha, ), removeOnComplete: true, - removeOnFail: 50, + // Match PR_METADATA (#75/#118) — failed files jobs must not squat + // on the stable per-SHA jobId (#124). + removeOnFail: true, attempts: 3, backoff: { type: "exponential", delay: 5000 }, }, diff --git a/packages/das/src/webhook/handlers/pull-request.handler.ts b/packages/das/src/webhook/handlers/pull-request.handler.ts index 53dbee8..85f54c9 100644 --- a/packages/das/src/webhook/handlers/pull-request.handler.ts +++ b/packages/das/src/webhook/handlers/pull-request.handler.ts @@ -118,7 +118,9 @@ export class PullRequestHandler { { jobId, removeOnComplete: true, - removeOnFail: 50, + // Match PR_METADATA (#75/#118) — failed files jobs must not squat + // on the stable per-SHA jobId (#124). + removeOnFail: true, attempts: 3, backoff: { type: "exponential", delay: 5000 }, },