RSSReader breaks down on shortener's error

[mrshu]

An important feature of RSSReader is sending the links in shortened form. This happens right before the link is sent https://github.com/errbotters/err-rssreader/blob/master/rssreader.py#L185

Sometimes, however, the shortener raises an exception. This is a pretty serious problem, as the cache never gets cleaned and the result is repeated sending of the same items over and over again.

Since we currently make use of just the is.gd shortener, fixing this should be as easy as handling the ShorteningErrorException correctly (just by returning from the function right away).

[mrshu]

@Adman since you added the shortening in the first place (if I am not mistaken), does the plan outlined in the previous comment make sense to you? I'd like to know your perspective.

[Adman]

@mrshu I think you programmed whole plugin including shortening, didn't you? I just suggested adding some url shortener.

I strongly agree with fixing this bug the way you mentioned in first comment.
But what if this problem persists for a longer time and the bot will not be able to send any rss feed?

[mrshu]

But what if this problem persists for a longer time and the bot will not be able to send any rss feed?

If my reading of the code currently in master is correct, the fix would only made sure that the execution gets past this line and thus the other messages should get delivered and the cache cleared. Should the issue with the shortener fix itself, the link should be sendable next time.

Does that make sense?

[Adman]

Makes sense.