feat(review): weight feedback reinforcement by trust

Author: haasonsaas

TODO.md

@@ -26,7 +26,7 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 2. [x] Infer "addressed by later commit" by diffing follow-up pushes against the original commented lines.
 3. [x] Feed addressed/not-addressed outcomes into the reinforcement store alongside thumbs.
 4. [x] Separate false-positive rejections from "valid but won't fix" dismissals in stored feedback.
-5. [ ] Weight reinforcement by reviewer role or trust level when GitHub identity is available.
+5. [x] Weight reinforcement by reviewer role or trust level when GitHub identity is available.
 6. [x] Add rule-level reinforcement decay so old team preferences do not dominate forever.
 7. [x] Add path-scoped reinforcement buckets so teams can prefer different standards in `tests/`, `scripts/`, and production code.
 8. [x] Persist explanation text from follow-up feedback replies and mine it into reusable review guidance.

src/commands/feedback_eval/input.rs

@@ -97,6 +97,7 @@ mod tests {
                 file_patterns: vec!["*.rs".to_string()],
                 accepted: false,
                 created_at: "2026-03-13T00:00:00Z".to_string(),
+                weight: 1.0,
                 embedding: vec![],
             }],
             embedding: Default::default(),

src/core/semantic.rs

@@ -51,14 +51,16 @@ impl SemanticFeedbackStore {
             &example.file_patterns,
             example.accepted,
         );
-        if self.examples.iter().any(|existing| {
+        if let Some(existing) = self.examples.iter_mut().find(|existing| {
             feedback_example_fingerprint(
                 &existing.content,
                 &existing.category,
                 &existing.file_patterns,
                 existing.accepted,
             ) == fingerprint
         }) {
+            existing.weight += example.weight.max(0.0);
+            existing.created_at = example.created_at;
             return;
         }
         self.examples.push(example);
@@ -696,11 +698,18 @@ mod tests {
             file_patterns: vec!["*.rs".to_string()],
             accepted: false,
             created_at: "2026-03-13T00:00:00Z".to_string(),
+            weight: 1.0,
             embedding: local_hash_embedding("Style nit"),
         };
         store.add_example(example.clone());
-        store.add_example(example);
+        store.add_example(SemanticFeedbackExample {
+            weight: 1.5,
+            created_at: "2026-03-14T00:00:00Z".to_string(),
+            ..example
+        });
         assert_eq!(store.examples.len(), 1);
+        assert!((store.examples[0].weight - 2.5).abs() < f32::EPSILON);
+        assert_eq!(store.examples[0].created_at, "2026-03-14T00:00:00Z");
     }
 
     #[tokio::test]

src/core/semantic/types.rs

@@ -39,6 +39,8 @@ pub struct SemanticFeedbackExample {
     pub file_patterns: Vec<String>,
     pub accepted: bool,
     pub created_at: String,
+    #[serde(default = "default_feedback_weight")]
+    pub weight: f32,
     pub embedding: Vec<f32>,
 }
 
@@ -50,6 +52,10 @@ pub struct SemanticFeedbackStore {
     pub embedding: SemanticEmbeddingMetadata,
 }
 
+fn default_feedback_weight() -> f32 {
+    1.0
+}
+
 #[derive(Debug, Clone, Serialize, Deserialize, Default, PartialEq, Eq)]
 pub struct SemanticFileState {
     pub content_hash: String,

src/review/feedback.rs

@@ -20,17 +20,21 @@ pub use persistence::{load_feedback_store, load_feedback_store_from_path, save_f
 #[allow(unused_imports)]
 pub use record::{
     apply_comment_dismissal_signal, apply_comment_feedback_signal,
-    apply_comment_feedback_signal_at, apply_comment_resolution_outcome_signal,
-    apply_comment_resolution_outcome_signal_at, record_comment_dismissal_stats,
-    record_comment_feedback_stats, record_comment_feedback_stats_at,
+    apply_comment_feedback_signal_at, apply_comment_feedback_signal_with_weight,
+    apply_comment_resolution_outcome_signal, apply_comment_resolution_outcome_signal_at,
+    record_comment_dismissal_stats, record_comment_feedback_stats,
+    record_comment_feedback_stats_at, record_comment_feedback_stats_with_weight,
     record_comment_resolution_stats, record_comment_resolution_stats_at, CommentResolutionOutcome,
 };
 #[allow(unused_imports)]
-pub use semantic::{record_semantic_feedback_example, record_semantic_feedback_examples};
+pub use semantic::{
+    record_semantic_feedback_example, record_semantic_feedback_examples,
+    record_semantic_feedback_examples_with_weight,
+};
 #[allow(unused_imports)]
 pub use store::{
-    DecayedFeedbackStats, FeedbackExplanation, FeedbackPatternStats, FeedbackStore,
-    FeedbackTypeStats,
+    DecayedFeedbackStats, FeedbackActorMetadata, FeedbackExplanation, FeedbackPatternStats,
+    FeedbackStore, FeedbackTypeStats,
 };
 
 #[cfg(test)]
@@ -53,6 +57,7 @@ mod tests {
         assert!(store.by_rule.is_empty());
         assert!(store.by_rule_file_pattern.is_empty());
         assert!(store.explanations_by_comment.is_empty());
+        assert!(store.feedback_actor_by_comment.is_empty());
     }
 
     #[test]
@@ -83,14 +88,12 @@ mod tests {
             FeedbackPatternStats {
                 accepted: 1,
                 rejected: 2,
-                dismissed: 0,
-                addressed: 0,
-                not_addressed: 0,
                 decayed: Some(DecayedFeedbackStats {
                     positive: 0.75,
                     negative: 1.25,
                     last_event_at: Some(123),
                 }),
+                ..Default::default()
             },
         );
         store.by_comment_type.insert(
@@ -101,6 +104,7 @@ mod tests {
                 dismissed: 3,
                 addressed: 4,
                 not_addressed: 5,
+                ..Default::default()
             },
         );
         store.explanations_by_comment.insert(
@@ -116,6 +120,15 @@ mod tests {
                 updated_at: "2026-03-15T00:00:00Z".to_string(),
             },
         );
+        store.feedback_actor_by_comment.insert(
+            "review-1::comment-1".to_string(),
+            FeedbackActorMetadata {
+                github_login: Some("maintainer".to_string()),
+                github_role: Some("write".to_string()),
+                trust_weight: 1.5,
+                updated_at: "2026-03-15T00:00:00Z".to_string(),
+            },
+        );
 
         let json = serde_json::to_string(&store).unwrap();
         let deserialized: FeedbackStore = serde_json::from_str(&json).unwrap();
@@ -134,6 +147,12 @@ mod tests {
             Some(2.0)
         );
         assert_eq!(deserialized.explanations_by_comment.len(), 1);
+        assert_eq!(
+            deserialized.feedback_actor_by_comment["review-1::comment-1"]
+                .github_role
+                .as_deref(),
+            Some("write")
+        );
     }
 
     #[test]
@@ -155,11 +174,7 @@ mod tests {
     fn pattern_stats_acceptance_rate_all_accepted() {
         let stats = FeedbackPatternStats {
             accepted: 10,
-            rejected: 0,
-            dismissed: 0,
-            addressed: 0,
-            not_addressed: 0,
-            decayed: None,
+            ..Default::default()
         };
         assert_eq!(stats.acceptance_rate(), 1.0);
         assert_eq!(stats.total(), 10);
@@ -168,12 +183,8 @@ mod tests {
     #[test]
     fn pattern_stats_acceptance_rate_all_rejected() {
         let stats = FeedbackPatternStats {
-            accepted: 0,
             rejected: 10,
-            dismissed: 0,
-            addressed: 0,
-            not_addressed: 0,
-            decayed: None,
+            ..Default::default()
         };
         assert_eq!(stats.acceptance_rate(), 0.0);
     }
@@ -183,23 +194,48 @@ mod tests {
         let stats = FeedbackPatternStats {
             accepted: 3,
             rejected: 7,
-            dismissed: 0,
-            addressed: 0,
-            not_addressed: 0,
-            decayed: None,
+            ..Default::default()
         };
         assert!((stats.acceptance_rate() - 0.3).abs() < f32::EPSILON);
     }
 
+    #[test]
+    fn pattern_stats_weighted_acceptance_rate_prefers_weighted_signal() {
+        let stats = FeedbackPatternStats {
+            accepted: 1,
+            rejected: 1,
+            accepted_weight: 3.0,
+            rejected_weight: 1.0,
+            ..Default::default()
+        };
+
+        assert!((stats.weighted_acceptance_rate() - 0.75).abs() < f32::EPSILON);
+        assert!((stats.weighted_total() - 4.0).abs() < f32::EPSILON);
+    }
+
+    #[test]
+    fn pattern_stats_weighted_acceptance_rate_preserves_legacy_counts_without_weights() {
+        let stats = FeedbackPatternStats {
+            accepted: 1,
+            addressed: 1,
+            rejected: 1,
+            accepted_weight: 2.0,
+            ..Default::default()
+        };
+
+        assert!((stats.weighted_positive_total() - 3.0).abs() < f32::EPSILON);
+        assert!((stats.weighted_negative_total() - 1.0).abs() < f32::EPSILON);
+        assert!((stats.weighted_acceptance_rate() - 0.75).abs() < f32::EPSILON);
+    }
+
     #[test]
     fn pattern_stats_acceptance_rate_includes_outcome_signals() {
         let stats = FeedbackPatternStats {
             accepted: 1,
             rejected: 1,
-            dismissed: 0,
             addressed: 3,
             not_addressed: 1,
-            decayed: None,
+            ..Default::default()
         };
 
         assert!((stats.acceptance_rate() - (4.0 / 6.0)).abs() < f32::EPSILON);
@@ -416,6 +452,26 @@ mod tests {
             "Tenant isolation must stay explicit to avoid cross-account reads.",
             "2026-03-15T00:01:00Z",
         ));
+        assert!(store.record_feedback_actor(
+            "review-1",
+            "comment-1",
+            FeedbackActorMetadata {
+                github_login: Some("repo-owner".to_string()),
+                github_role: Some("admin".to_string()),
+                trust_weight: 2.0,
+                updated_at: "2026-03-15T00:00:00Z".to_string(),
+            }
+        ));
+        assert!(store.record_feedback_actor(
+            "review-2",
+            "comment-2",
+            FeedbackActorMetadata {
+                github_login: Some("triager".to_string()),
+                github_role: Some("triage".to_string()),
+                trust_weight: 1.25,
+                updated_at: "2026-03-15T00:01:00Z".to_string(),
+            }
+        ));
 
         let context = generate_feedback_context(&store);
         assert!(

src/review/feedback/context.rs

@@ -5,8 +5,9 @@ const MAX_EXPLANATION_GUIDANCE_ITEMS: usize = 4;
 
 #[derive(Default)]
 struct ExplanationGuidanceBucket {
-    accepted: usize,
-    rejected: usize,
+    observations: usize,
+    accepted: f32,
+    rejected: f32,
     snippets: Vec<String>,
 }
 
@@ -22,7 +23,7 @@ pub fn generate_feedback_context(store: &FeedbackStore) -> String {
         if stats.total() < min_observations {
             continue;
         }
-        let rate = stats.acceptance_rate();
+        let rate = stats.weighted_acceptance_rate();
         if rate >= 0.7 {
             patterns.push(format!(
                 "- {} findings usually produce positive outcomes ({:.0}% positive reinforcement rate) — be thorough on {} issues",
@@ -40,7 +41,7 @@ pub fn generate_feedback_context(store: &FeedbackStore) -> String {
         if stats.total() < min_observations {
             continue;
         }
-        let rate = stats.acceptance_rate();
+        let rate = stats.weighted_acceptance_rate();
         if rate < 0.3 {
             patterns.push(format!(
                 "- Comments on {} files rarely produce positive outcomes ({:.0}% positive reinforcement rate) — be more conservative",
@@ -52,16 +53,21 @@ pub fn generate_feedback_context(store: &FeedbackStore) -> String {
     let mut explanation_buckets =
         std::collections::HashMap::<String, ExplanationGuidanceBucket>::new();
     for explanation in store.explanations_by_comment.values() {
+        let trust_weight = store
+            .feedback_actor(&explanation.review_id, &explanation.comment_id)
+            .map(|actor| actor.trust_weight)
+            .unwrap_or(1.0);
         let bucket_key = explanation
             .rule_id
             .as_deref()
             .map(|rule_id| format!("rule::{rule_id}"))
             .unwrap_or_else(|| format!("category::{}", explanation.category));
         let bucket = explanation_buckets.entry(bucket_key).or_default();
+        bucket.observations += 1;
         if explanation.action == "accept" {
-            bucket.accepted += 1;
+            bucket.accepted += trust_weight;
         } else {
-            bucket.rejected += 1;
+            bucket.rejected += trust_weight;
         }
 
         if let Some(snippet) = explanation_snippet(&explanation.text) {
@@ -79,9 +85,9 @@ pub fn generate_feedback_context(store: &FeedbackStore) -> String {
         .into_iter()
         .filter_map(|(bucket_key, bucket)| {
             let total = bucket.accepted + bucket.rejected;
-            if total < MIN_EXPLANATION_OBSERVATIONS
+            if bucket.observations < MIN_EXPLANATION_OBSERVATIONS
                 || bucket.snippets.is_empty()
-                || bucket.accepted == bucket.rejected
+                || (bucket.accepted - bucket.rejected).abs() <= f32::EPSILON
             {
                 return None;
             }
@@ -114,8 +120,12 @@ pub fn generate_feedback_context(store: &FeedbackStore) -> String {
             }
         })
         .collect::<Vec<_>>();
-    explanation_guidance
-        .sort_by(|left, right| right.0.cmp(&left.0).then_with(|| left.1.cmp(&right.1)));
+    explanation_guidance.sort_by(|left, right| {
+        right
+            .0
+            .total_cmp(&left.0)
+            .then_with(|| left.1.cmp(&right.1))
+    });
     patterns.extend(
         explanation_guidance
             .into_iter()