refactor: address round 4 review comments

1. Remove isCommandOutput helper — inline instanceof check directly
   in handleYieldedValue.

2. Remove onPolling callback from DeviceFlowCallbacks in oauth.ts —
   spinner handles visual feedback now.

3. Convert 11 "yield new CommandOutput(..); return;" patterns to
   "return yield new CommandOutput(..)" one-liners across 9 files.

4. Add output config to auth/token — emits token as structured data
   through the framework. JSON: {"token": "..."}, human: raw token.

5. Add output config to cli/setup — collects messages and warnings
   into SetupResult, yields through framework. JSON output includes
   structured messages/warnings/binaryPath/version.

6. Remove hasJsonOutput intermediate — use outputConfig directly.
   Only init.ts remains without output config (interactive wizard,
   deferred to separate PR).

Author: BYK

src/commands/api.ts

@@ -1210,7 +1210,6 @@ export const apiCommand = buildCommand({
       throw new OutputError(response.body);
     }
 
-    yield new CommandOutput(response.body);
-    return;
+    return yield new CommandOutput(response.body);
   },
 });

src/commands/auth/login.ts

@@ -182,8 +182,7 @@ export const loginCommand = buildCommand({
         // Non-fatal: user info is supplementary. Token remains stored and valid.
       }
 
-      yield new CommandOutput(result);
-      return;
+      return yield new CommandOutput(result);
     }
 
     // OAuth device flow

src/commands/auth/refresh.ts

@@ -105,7 +105,6 @@ Examples:
         : undefined,
     };
 
-    yield new CommandOutput(payload);
-    return;
+    return yield new CommandOutput(payload);
   },
 });

src/commands/auth/status.ts

@@ -190,7 +190,6 @@ export const statusCommand = buildCommand({
       verification: await verifyCredentials(),
     };
 
-    yield new CommandOutput(data);
-    return;
+    return yield new CommandOutput(data);
   },
 });

src/commands/auth/token.ts

@@ -9,30 +9,25 @@ import type { SentryContext } from "../../context.js";
 import { buildCommand } from "../../lib/command.js";
 import { getAuthToken } from "../../lib/db/auth.js";
 import { AuthError } from "../../lib/errors.js";
+import { CommandOutput, stateless } from "../../lib/formatters/output.js";
 
 export const tokenCommand = buildCommand({
   docs: {
     brief: "Print the stored authentication token",
     fullDescription:
       "Print the stored authentication token to stdout.\n\n" +
       "This outputs the raw token without any formatting, making it suitable for " +
-      "piping to other commands or scripts. The token is printed without a trailing newline " +
-      "when stdout is not a TTY (e.g., when piped).",
+      "piping to other commands or scripts.",
   },
   parameters: {},
-  // biome-ignore lint/correctness/useYield: void generator — writes to stdout directly
+  output: { human: stateless((token: string) => token) },
   // biome-ignore lint/suspicious/useAwait: sync body but async generator required by buildCommand
   async *func(this: SentryContext) {
-    const { stdout } = this;
-
     const token = getAuthToken();
     if (!token) {
       throw new AuthError("not_authenticated");
     }
 
-    // Add newline only if stdout is a TTY (interactive terminal)
-    // When piped, omit newline for cleaner output
-    const suffix = process.stdout.isTTY ? "\n" : "";
-    stdout.write(`${token}${suffix}`);
+    return yield new CommandOutput(token);
   },
 });

src/commands/auth/whoami.ts

@@ -65,7 +65,6 @@ export const whoamiCommand = buildCommand({
       // Cache update failure is non-essential — user identity was already fetched.
     }
 
-    yield new CommandOutput(user);
-    return;
+    return yield new CommandOutput(user);
   },
 });

src/commands/cli/fix.ts

@@ -735,7 +735,6 @@ export const fixCommand = buildCommand({
       throw new OutputError(result);
     }
 
-    yield new CommandOutput(result);
-    return;
+    return yield new CommandOutput(result);
   },
 });

src/commands/cli/setup.ts

@@ -27,7 +27,7 @@ import {
   type ReleaseChannel,
   setReleaseChannel,
 } from "../../lib/db/release-channel.js";
-import { logger } from "../../lib/logger.js";
+import { CommandOutput, stateless } from "../../lib/formatters/output.js";
 import {
   addToGitHubPath,
   addToPath,
@@ -42,8 +42,6 @@ import {
   parseInstallationMethod,
 } from "../../lib/upgrade.js";
 
-const log = logger.withTag("cli.setup");
-
 type SetupFlags = {
   readonly install: boolean;
   readonly method?: InstallationMethod;
@@ -56,6 +54,31 @@ type SetupFlags = {
 
 type Logger = (msg: string) => void;
 
+/** Structured result of the setup operation */
+type SetupResult = {
+  /** Status messages collected during setup */
+  messages: string[];
+  /** Warning messages from best-effort steps */
+  warnings: string[];
+  /** Whether a fresh binary was installed */
+  freshInstall: boolean;
+  /** Path to the installed binary */
+  binaryPath: string;
+  /** CLI version */
+  version: string;
+};
+
+/** Format setup result for human-readable output */
+function formatSetupResult(result: SetupResult): string {
+  const lines: string[] = [...result.messages];
+  if (result.warnings.length > 0) {
+    for (const w of result.warnings) {
+      lines.push(`⚠ ${w}`);
+    }
+  }
+  return lines.join("\n");
+}
+
 /**
  * Handle binary installation from a temp location.
  *
@@ -441,19 +464,23 @@ export const setupCommand = buildCommand({
       },
     },
   },
+  output: { human: stateless(formatSetupResult) },
   async *func(this: SentryContext, flags: SetupFlags) {
     const { process, homeDir } = this;
 
+    const messages: string[] = [];
+    const warnings: string[] = [];
+
     const emit: Logger = (msg: string) => {
       if (!flags.quiet) {
-        log.info(msg);
+        messages.push(msg);
       }
     };
 
     const warn: WarnLogger = (step, error) => {
       const msg =
         error instanceof Error ? error.message : "Unknown error occurred";
-      log.warn(`${step} failed: ${msg}`);
+      warnings.push(`${step} failed: ${msg}`);
     };
 
     let binaryPath = process.execPath;
@@ -489,5 +516,13 @@ export const setupCommand = buildCommand({
     if (!flags.quiet && freshInstall) {
       printWelcomeMessage(emit, CLI_VERSION, binaryPath);
     }
+
+    return yield new CommandOutput<SetupResult>({
+      messages,
+      warnings,
+      freshInstall,
+      binaryPath,
+      version: CLI_VERSION,
+    });
   },
 });

src/commands/cli/upgrade.ts

@@ -494,8 +494,7 @@ export const upgradeCommand = buildCommand({
       flags,
     });
     if (resolved.kind === "done") {
-      yield new CommandOutput(resolved.result);
-      return;
+      return yield new CommandOutput(resolved.result);
     }
 
     const { target } = resolved;

src/commands/issue/plan.ts

@@ -225,8 +225,7 @@ export const planCommand = buildCommand({
       if (!flags.force) {
         const existingSolution = extractSolution(state);
         if (existingSolution) {
-          yield new CommandOutput(buildPlanData(state));
-          return;
+          return yield new CommandOutput(buildPlanData(state));
         }
       }
 
@@ -261,8 +260,7 @@ export const planCommand = buildCommand({
         throw new Error("Plan creation was cancelled.");
       }
 
-      yield new CommandOutput(buildPlanData(finalState));
-      return;
+      return yield new CommandOutput(buildPlanData(finalState));
     } catch (error) {
       // Handle API errors with friendly messages
       if (error instanceof ApiError) {