Skip to content

Commit da999ee

Browse files
committed
Address review comments
1 parent 6f2cc43 commit da999ee

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,9 @@ predicate containerStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
188188
exists(DataFlow::Content c | c = contentSet.getAReadContent() |
189189
c instanceof DataFlow::TupleElementContent or
190190
c instanceof DataFlow::DictionaryElementContent or
191-
c instanceof DataFlow::DictionaryElementAnyContent
191+
c instanceof DataFlow::DictionaryElementAnyContent or
192+
c instanceof DataFlow::ListElementContent or
193+
c instanceof DataFlow::SetElementContent
192194
)
193195
)
194196
}

python/ql/lib/semmle/python/frameworks/Stdlib.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4983,10 +4983,6 @@ module StdlibPrivate {
49834983
// For code like `" ".join([name])`
49844984
input = "Argument[0,iterable:].ListElement" and
49854985
preservesValue = true
4986-
or
4987-
// For code like `" ".join(name)`
4988-
input = "Argument[0,iterable:]" and
4989-
preservesValue = false
49904986
) and
49914987
output = "ReturnValue"
49924988
}

0 commit comments

Comments
 (0)