From b0b08fe3f958e4b2bb994676afdf53af448ac5fa Mon Sep 17 00:00:00 2001 From: Artur Kordowski <9746197+akordowski@users.noreply.github.com> Date: Thu, 26 Feb 2026 10:42:53 +0100 Subject: [PATCH 1/2] Make the `--target-uploads-url` option visible to the help output --- src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs | 3 +-- src/gei/Commands/GenerateScript/GenerateScriptCommand.cs | 3 +-- src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs | 3 +-- src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs b/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs index c93b5eaa9..c14b0ac32 100644 --- a/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs +++ b/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs @@ -193,8 +193,7 @@ public MigrateRepoCommand() : base( }; public Option TargetUploadsUrl { get; } = new( name: "--target-uploads-url", - description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com") - { IsHidden = true }; + description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com"); public Option NoSslVerify { get; } = new( name: "--no-ssl-verify", description: "Disables SSL verification when communicating with your Bitbucket Server/Data Center instance. All other migration steps will continue to verify SSL. " + diff --git a/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs b/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs index d0e273948..6d24f20a0 100644 --- a/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs +++ b/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs @@ -103,8 +103,7 @@ public GenerateScriptCommand() : base( }; public Option TargetUploadsUrl { get; } = new( name: "--target-uploads-url", - description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com") - { IsHidden = true }; + description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com"); public Option UseGithubStorage { get; } = new("--use-github-storage") { IsHidden = true, diff --git a/src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs b/src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs index 6f06d42b5..4738d2b42 100644 --- a/src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs +++ b/src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs @@ -48,8 +48,7 @@ public MigrateOrgCommand() : base( }; public Option TargetUploadsUrl { get; } = new( name: "--target-uploads-url", - description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com") - { IsHidden = true }; + description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com"); public Option QueueOnly { get; } = new("--queue-only") { Description = "Only queues the migration, does not wait for it to finish. Use the wait-for-migration command to subsequently wait for it to finish and view the status." diff --git a/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs b/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs index 409dce2d5..4212d6fd9 100644 --- a/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs +++ b/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs @@ -69,8 +69,7 @@ public MigrateRepoCommand() : base( }; public Option TargetUploadsUrl { get; } = new( name: "--target-uploads-url", - description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com") - { IsHidden = true }; + description: "The URL of the target uploads API, if not migrating to github.com. Defaults to https://uploads.github.com"); // GHES migration path public Option GhesApiUrl { get; } = new("--ghes-api-url") From cd973e81763e38e4f0bbf02de73896f006f2aa0c Mon Sep 17 00:00:00 2001 From: Artur Kordowski <9746197+akordowski@users.noreply.github.com> Date: Thu, 26 Feb 2026 11:19:04 +0100 Subject: [PATCH 2/2] Fix unit tests --- .../bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs | 2 +- .../gei/Commands/GenerateScript/GenerateScriptCommandTests.cs | 2 +- .../gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs | 2 +- .../gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs b/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs index 625130223..b0697a355 100644 --- a/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs +++ b/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs @@ -90,7 +90,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "keep-archive", false); TestHelpers.VerifyCommandOption(command.Options, "no-ssl-verify", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); - TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); + TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false); TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false, true); } diff --git a/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs b/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs index b2eb3f2d9..e8e5945fa 100644 --- a/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs +++ b/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs @@ -56,7 +56,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "aws-region", false); TestHelpers.VerifyCommandOption(command.Options, "keep-archive", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); - TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); + TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false); TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false, true); } diff --git a/src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs b/src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs index 2c6e3beb9..846c8da9a 100644 --- a/src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs +++ b/src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs @@ -46,7 +46,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "github-target-pat", false); TestHelpers.VerifyCommandOption(command.Options, "verbose", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); - TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); + TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false); } [Fact] diff --git a/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs b/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs index 26d039592..ccacca55c 100644 --- a/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs +++ b/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs @@ -20,7 +20,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "github-target-org", true); TestHelpers.VerifyCommandOption(command.Options, "target-repo", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); - TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); + TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false); TestHelpers.VerifyCommandOption(command.Options, "ghes-api-url", false); TestHelpers.VerifyCommandOption(command.Options, "azure-storage-connection-string", false); TestHelpers.VerifyCommandOption(command.Options, "aws-bucket-name", false);