Security: Dead code in read function - unused return value#311
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
In sonnet/src/nets/dnc/read.py, the squash_op(weights) call on line 36 has its return value discarded. The function is called for its side effect but the squashed result is never used, meaning the squash_before_access parameter has no effect. Affected files: read.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In sonnet/src/nets/dnc/read.py, the squash_op(weights) call on line 36 has its return value discarded. The function is called for its side effect but the squashed result is never used, meaning the squash_before_access parameter has no effect.
Severity:
lowFile:
sonnet/src/nets/dnc/read.pySolution
Either use the return value: weights = squash_op(weights), or remove the parameter if squashing before access is not needed.
Changes
sonnet/src/nets/dnc/read.py(modified)Testing