From 1f14cfc61b41934afca44c970c96f34871fb05bf Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 17 Mar 2026 10:55:29 -0700 Subject: [PATCH 1/3] chore: improve typing in api_core.exceptions GoogleApiCallError.grpc_status_code had no typing, so mypy will assume the value is always None --- packages/google-api-core/google/api_core/exceptions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google-api-core/google/api_core/exceptions.py b/packages/google-api-core/google/api_core/exceptions.py index e3eb696c7c5e..526121420acc 100644 --- a/packages/google-api-core/google/api_core/exceptions.py +++ b/packages/google-api-core/google/api_core/exceptions.py @@ -121,7 +121,7 @@ class GoogleAPICallError(GoogleAPIError, metaclass=_GoogleAPICallErrorMeta): (google.rpc.error_details.ErrorInfo). """ - code: Union[int, None] = None + code: Optional[int] = None """Optional[int]: The HTTP status code associated with this error. This may be ``None`` if the exception does not have a direct mapping @@ -130,7 +130,7 @@ class GoogleAPICallError(GoogleAPIError, metaclass=_GoogleAPICallErrorMeta): See http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html """ - grpc_status_code = None + grpc_status_code: Optional[grpc.StatusCode] = None """Optional[grpc.StatusCode]: The gRPC status code associated with this error. From f9852178a0db890b35cee68ad63532bebf737ae8 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 17 Mar 2026 11:05:03 -0700 Subject: [PATCH 2/3] Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- packages/google-api-core/google/api_core/exceptions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google-api-core/google/api_core/exceptions.py b/packages/google-api-core/google/api_core/exceptions.py index 526121420acc..4d032cd8bdb3 100644 --- a/packages/google-api-core/google/api_core/exceptions.py +++ b/packages/google-api-core/google/api_core/exceptions.py @@ -130,7 +130,7 @@ class GoogleAPICallError(GoogleAPIError, metaclass=_GoogleAPICallErrorMeta): See http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html """ - grpc_status_code: Optional[grpc.StatusCode] = None + grpc_status_code: Optional["grpc.StatusCode"] = None """Optional[grpc.StatusCode]: The gRPC status code associated with this error. From ab6ee7146ff55c4ffc4e7a81450b0ace6ef87308 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Wed, 18 Mar 2026 15:08:35 -0700 Subject: [PATCH 3/3] removed import --- packages/google-api-core/google/api_core/exceptions.py | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/google-api-core/google/api_core/exceptions.py b/packages/google-api-core/google/api_core/exceptions.py index 4d032cd8bdb3..e17fa1d8d137 100644 --- a/packages/google-api-core/google/api_core/exceptions.py +++ b/packages/google-api-core/google/api_core/exceptions.py @@ -23,7 +23,6 @@ import http.client from typing import Optional, Dict -from typing import Union import warnings from google.rpc import error_details_pb2