chore: bump ESLint to latest version and fix new issues

GordonSmith · GordonSmith · commit ea689a4a151c · 2026-04-10T11:04:57.000+01:00
Signed-off-by: Gordon Smith &lt;GordonJSmith@gmail.com&gt;
diff --git a/eslint.config.ts b/eslint.config.ts
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,14 +37,17 @@
     "update-major": "run-p update-major-workspaces update-major-root"
   },
   "devDependencies": {
+    "@eslint/js": "10.0.1",
     "@types/esbuild-copy-static-files": "0.1.4",
     "@typescript-eslint/parser": "8.58.1",
     "@vitest/browser": "3.2.4",
     "@vitest/coverage-v8": "3.2.4",
     "cross-env": "10.1.0",
     "esbuild": "0.28.0",
-    "eslint": "9.39.4",
+    "eslint": "10.2.0",
     "eslint-plugin-react-hooks": "7.0.1",
+    "globals": "17.4.0",
+    "jiti": "2.6.1",
     "lerna": "9.0.7",
     "npm-run-all": "4.1.5",
     "playwright": "1.59.1",
@@ -64,6 +67,9 @@
       "minimatch": "10.2.3"
     },
     "esbuild": "$esbuild",
+    "eslint-plugin-react-hooks": {
+      "eslint": "$eslint"
+    },
     "tar": "7.5.11",
     "tmp": "0.2.5",
     "typescript": "$typescript",
diff --git a/packages/common/src/Database.ts b/packages/common/src/Database.ts
@@ -393,8 +393,7 @@ export class Grid extends PropertyExt {
 
     //  Hipie Helpers  ---
 
-    hipieMappings(columns, missingDataString) {
-        missingDataString = missingDataString || "";
+    hipieMappings(columns, _missingDataString?) {
         if (!this.fields().length || !this._data.length) {
             return [];
         }
diff --git a/packages/common/src/Platform.ts b/packages/common/src/Platform.ts
@@ -76,21 +76,20 @@ export function getScrollbarWidth() {
     };
 
     this.observe = function (domNode, config) {
-        let listener = null;
         if (config.attributes) {
-            listener = new MutationListener(this.callback, domNode, "attributes");
+            const listener = new MutationListener(this.callback, domNode, "attributes");
             this.listeners.push(listener);
             domNode.addEventListener("DOMAttrModified", listener, true);
         }
 
         if (config.characterData) {
-            listener = new MutationListener(this.callback, domNode, "characterData");
+            const listener = new MutationListener(this.callback, domNode, "characterData");
             this.listeners.push(listener);
             domNode.addEventListener("DOMCharacterDataModified", listener, true);
         }
 
         if (config.childList) {
-            listener = new MutationListener(this.callback, domNode, "childList");
+            const listener = new MutationListener(this.callback, domNode, "childList");
             this.listeners.push(listener);
             domNode.addEventListener("DOMNodeInserted", listener, true);
             domNode.addEventListener("DOMNodeRemoved", listener, true);
diff --git a/packages/common/src/Utility.ts b/packages/common/src/Utility.ts
@@ -601,7 +601,7 @@ export function timestamp() {
 export function downloadString(format: "CSV" | "TSV" | "JSON" | "TEXT" | "SVG", blob: string, id?: string) {
     const filename = id || ("data_" + timestamp()) + "." + format.toLowerCase();
 
-    let mimeType = "";
+    let mimeType: string;
     switch (format) {
         case "TSV":
             mimeType = "text/tab-seperated-values";
diff --git a/packages/comms/src/ecl/scope.ts b/packages/comms/src/ecl/scope.ts
@@ -152,9 +152,8 @@ export class BaseScope extends StateObject<ScopeEx, ScopeEx> implements ScopeEx
     }
 
     calcTooltip(parentScope?: BaseScope) {
-        let label = "";
+        let label = this.Id;
         const rows: string[] = [];
-        label = this.Id;
         rows.push(`<tr><td class="key">ID:</td><td class="value">${this.Id}</td></tr>`);
         if (parentScope) {
             rows.push(`<tr><td class="key">Parent ID:</td><td class="value">${parentScope.Id}</td></tr>`);
diff --git a/packages/composite/src/MegaChart.ts b/packages/composite/src/MegaChart.ts
@@ -133,7 +133,7 @@ export class MegaChart extends Border {
             ;
         this._maximizeButton.click = function (buttonWidget) {
             const target = context.target() as any;
-            let node = target;
+            let node;
             const isMaximized = d3Select(target).classed("__hpccisMaximized");
 
             // Find the layout_Grid ancestor
diff --git a/packages/graph/src/common/layouts/dagre.ts b/packages/graph/src/common/layouts/dagre.ts
@@ -113,8 +113,8 @@ export class Dagre extends Layout {
         if (ep.points) {
             const line = this.edgeLine(ep);
             points = ep.points.map((p, idx) => {
-                let x = NaN;
-                let y = NaN;
+                let x: number;
+                let y: number;
                 if (idx === 0) {
                     x = this._graph.rproject(line.source.x);
                     y = this._graph.rproject(line.source.y);
diff --git a/packages/graph/src/common/layouts/graphviz.ts b/packages/graph/src/common/layouts/graphviz.ts
@@ -104,8 +104,8 @@ export class Graphviz extends Layout {
         if (ep.points) {
             const line = this.edgeLine(ep);
             points = ep.points.map((p, idx) => {
-                let x = NaN;
-                let y = NaN;
+                let x: number;
+                let y: number;
                 if (idx === 0) {
                     x = this._graph.rproject(line.source.x);
                     y = this._graph.rproject(line.source.y);
diff --git a/packages/map/src/CanvasPins.ts b/packages/map/src/CanvasPins.ts
@@ -34,7 +34,7 @@ class Quadtree {
     searchRect(left: number, top: number, right: number, bottom: number): CanvasPinRow[] {
         const ret: any = [];
         this._tree.visit((node: any, x1: number, y1: number, x2: number, y2: number) => {
-            let next_exists = false;
+            let next_exists;
             do {
                 if (!node.length) {
                     if (node.data && !node.data.already_flagged) {
diff --git a/packages/other/src/Legend.ts b/packages/other/src/Legend.ts
@@ -146,7 +146,7 @@ export class Legend extends Table {
         const start = startIndex * itemsOnPage;
         const end = startIndex * parseInt(itemsOnPage) + parseInt(itemsOnPage);
 
-        let tData = null;
+        let tData;
         if (this.pagination()) {
             tData = this.data().slice(start, end);
         } else {
diff --git a/packages/other/src/Table.ts b/packages/other/src/Table.ts
@@ -260,7 +260,7 @@ export class Table extends HTMLWidget {
         const start = startIndex * itemsOnPage;
         const end = startIndex * parseInt(itemsOnPage) + parseInt(itemsOnPage);
 
-        let tData = null;
+        let tData;
 
         if (this.topN()) {
             tData = data.slice(0, this.topN());
diff --git a/packages/other/src/ThemeEditor.ts b/packages/other/src/ThemeEditor.ts
@@ -308,7 +308,7 @@ export class ThemeEditor extends HTMLWidget {
         return html;
     }
     buildTableObjects(targetElement, propObjs) {
-        let sectionObjs = {};
+        let sectionObjs;
         if (this.themeMode()) {
             sectionObjs = {
                 chartColorSection: {
@@ -467,7 +467,7 @@ export class ThemeEditor extends HTMLWidget {
                             elm3 = elm3.parentElement.parentElement;
                         }
                         const parent = elm3.parentElement;
-                        let tbodyClass = "";
+                        let tbodyClass;
                         if (parent.className.split(" ").indexOf("expanded") === -1) {
                             parent.className = "te-section-table expanded";
                             tbodyClass = "shown";
@@ -487,7 +487,7 @@ export class ThemeEditor extends HTMLWidget {
                     label[0].onclick = function (e) {
                         const elm3 = e.toElement;
                         const parent = elm3.parentElement;
-                        let subRowClass = "";
+                        let subRowClass;
                         if (parent.className.split(" ").indexOf("expanded") === -1) {
                             parent.className = "sharedPropertyRow expanded";
                             subRowClass = "shown";

Original file line number	Diff line number	Diff line change
`@@ -393,8 +393,7 @@ export class Grid extends PropertyExt {`
`393`	`393`
`394`	`394`	`// Hipie Helpers ---`
`395`	`395`
`396`		`- hipieMappings(columns, missingDataString) {`
`397`		`- missingDataString = missingDataString \|\| "";`
	`396`	`+ hipieMappings(columns, _missingDataString?) {`
`398`	`397`	`if (!this.fields().length \|\| !this._data.length) {`
`399`	`398`	`return [];`
`400`	`399`	`}`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ export class MegaChart extends Border {`
`133`	`133`	`;`
`134`	`134`	`this._maximizeButton.click = function (buttonWidget) {`
`135`	`135`	`const target = context.target() as any;`
`136`		`- let node = target;`
	`136`	`+ let node;`
`137`	`137`	`const isMaximized = d3Select(target).classed("__hpccisMaximized");`
`138`	`138`
`139`	`139`	`// Find the layout_Grid ancestor`