From 7645e81d532ed75abc541a80b94ee4cddb20a854 Mon Sep 17 00:00:00 2001 From: Kris Kline Date: Thu, 19 Mar 2026 13:48:01 -0500 Subject: [PATCH 1/2] Attempting to do CI to run unit tests on all PRs. Limiting to just iPhone for now --- .github/workflows/pull-request-ci.yml | 62 +++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 .github/workflows/pull-request-ci.yml diff --git a/.github/workflows/pull-request-ci.yml b/.github/workflows/pull-request-ci.yml new file mode 100644 index 0000000..0d0bdb3 --- /dev/null +++ b/.github/workflows/pull-request-ci.yml @@ -0,0 +1,62 @@ +name: Pull Request CI + +on: + pull_request: + workflow_dispatch: + +concurrency: + group: pull-request-ci-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + unit-tests: + name: Unit Tests (${{ matrix.scheme }}) + runs-on: macos-latest + strategy: + fail-fast: false + matrix: + scheme: + - libPhoneNumber + - libPhoneNumberGeocoding + - libPhoneNumberShortNumber + + steps: + - name: Check out repository + uses: actions/checkout@v4 + + - name: Run unit tests + env: + SCHEME: ${{ matrix.scheme }} + run: | + set -eo pipefail + + xcodebuild \ + -project libPhoneNumber.xcodeproj \ + -scheme "$SCHEME" \ + -destination 'platform=iOS Simulator,name=iPhone,OS=latest' \ + CODE_SIGNING_ALLOWED=NO \ + test + + podspec-lint: + name: Podspec Lint (${{ matrix.podspec }}) + runs-on: macos-latest + strategy: + fail-fast: false + matrix: + podspec: + - libPhoneNumber-iOS.podspec + - libPhoneNumberGeocoding.podspec + - libPhoneNumberShortNumber.podspec + + steps: + - name: Check out repository + uses: actions/checkout@v4 + + - name: Ensure CocoaPods is installed + run: | + if ! command -v pod >/dev/null; then + gem install cocoapods + fi + + - name: Lint podspec + run: pod lib lint "${{ matrix.podspec }}" --verbose From 96581e0f090d601ffef6215b8b21e57483d87909 Mon Sep 17 00:00:00 2001 From: Kris Kline Date: Thu, 19 Mar 2026 14:04:35 -0500 Subject: [PATCH 2/2] Specify "iPhone 17" --- .github/workflows/pull-request-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request-ci.yml b/.github/workflows/pull-request-ci.yml index 0d0bdb3..7ba1c66 100644 --- a/.github/workflows/pull-request-ci.yml +++ b/.github/workflows/pull-request-ci.yml @@ -33,7 +33,7 @@ jobs: xcodebuild \ -project libPhoneNumber.xcodeproj \ -scheme "$SCHEME" \ - -destination 'platform=iOS Simulator,name=iPhone,OS=latest' \ + -destination 'platform=iOS Simulator,OS=latest,name=iPhone 17' \ CODE_SIGNING_ALLOWED=NO \ test