From d37541bf36e773ff51f55d5fadc1c692183b89c4 Mon Sep 17 00:00:00 2001 From: Joely Date: Sat, 7 Nov 2026 14:34:28 -0500 Subject: [PATCH] Revert "components 0.5.5 (unpublished): Form.BusinessInfo showLocation, for a host that asks the address itself" This reverts commit 8557b80c2e02ab244ad3abdd132b9e60fc2e5409. It reached main without review: a VS Code sync on a branch that tracked origin/main pushed it (2026-11-07). The owner then chose another design: the store address is picked from Google's suggestions inside Form.BusinessInfo itself, once the library has a single entry (plan: retire lib/portable). main goes back to cf906c7, version 0.5.4, so nothing is published with showLocation. Co-Authored-By: Claude Opus 5.5 --- packages/components/package-lock.json | 4 +-- packages/components/package.json | 2 +- packages/components/src/Form/Form.stories.js | 14 -------- .../components/src/Form/FormBusinessInfo.js | 33 ++++++++----------- .../src/Form/__tests__/Form.test.js | 16 --------- 5 files changed, 17 insertions(+), 52 deletions(-) diff --git a/packages/components/package-lock.json b/packages/components/package-lock.json index 050c8300..093f6fb4 100644 --- a/packages/components/package-lock.json +++ b/packages/components/package-lock.json @@ -1,12 +1,12 @@ { "name": "@jmstechnologiesinc/react-native-components", - "version": "0.5.5", + "version": "0.5.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@jmstechnologiesinc/react-native-components", - "version": "0.5.5", + "version": "0.5.4", "license": "ISC", "devDependencies": { "@jmstechnologiesinc/partner": "0.2.54", diff --git a/packages/components/package.json b/packages/components/package.json index b228be14..6e6afe64 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@jmstechnologiesinc/react-native-components", - "version": "0.5.5", + "version": "0.5.4", "description": "Biblioteca de componentes de interfaz compartida por las aplicaciones de Daxir.", "author": "yerloveraaa ", "homepage": "https://github.com/jmstechnologiesinc/react-native-components#readme", diff --git a/packages/components/src/Form/Form.stories.js b/packages/components/src/Form/Form.stories.js index 1c0c25bb..d31d0f26 100644 --- a/packages/components/src/Form/Form.stories.js +++ b/packages/components/src/Form/Form.stories.js @@ -210,20 +210,6 @@ export const BusinessInfoHighlighted = () => ( /> ); -// The store sign-up's form: the app asks the address with Google's suggestions, so the form leaves its field out, as -// it leaves out the phone and the email. -export const BusinessInfoWithoutLocation = () => ( - {}} - /> -); - // The driver's answers as a reviewer sees them: read-only (no disclosure, the // secrets masked), a changed field marked and a server error under its field. export const DriverInfoReadOnly = () => ( diff --git a/packages/components/src/Form/FormBusinessInfo.js b/packages/components/src/Form/FormBusinessInfo.js index 0c10caff..bff71f9d 100644 --- a/packages/components/src/Form/FormBusinessInfo.js +++ b/packages/components/src/Form/FormBusinessInfo.js @@ -87,9 +87,6 @@ const FormBusinessInfo = ({ storeTitle, location, line2, - // A host that asks the store address with its own input (the app's Google suggestions, barrel only) hides this - // field, as the sign-up hides the phone and the email. - showLocation = true, showWebsite = true, showPhoneNumber = true, showEmail = true, @@ -141,22 +138,20 @@ const FormBusinessInfo = ({ onChangeText={(text) => inputActionHandler('description', text)} /> - {showLocation ? ( - - inputActionHandler('location', text)} - /> - - ) : null} + + inputActionHandler('location', text)} + /> + { expect(hidden.root.findAll((node) => node.props.value === 'Casa Nostra LLC')).toHaveLength(0); }); - // The app asks the store address with Google's suggestions (barrel only) and hides this field, as it hides the - // phone and the email; the field's own errors are then the host's to show. - it('hides the store address under showLocation={false}, and keeps the other fields', () => { - const hidden = render( - - ); - expect(inputWithValue(hidden, '1 Main St')).toBeUndefined(); - expect(hostOf(hidden, 'error.location')).toHaveLength(0); - expect(inputWithValue(hidden, 'Suite 2')).toBeDefined(); - expect(inputWithValue(render(), '1 Main St')).toBeDefined(); - }); - it('names the tax id on file (masked) instead of showing it', () => { const tree = render(); expect(JSON.stringify(tree.toJSON())).toContain('•••••6789');