Skip to content

fix: move secret check from job-level to step-level in sync-dashboard-team #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavobtflores merged 1 commit into from
May 20, 2026
+5 −2
Merged

fix: move secret check from job-level to step-level in sync-dashboard-team #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/sync-dashboard-team.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ permissions:
jobs:
# Add validation checks for Pull Requests
validate:
if: github.event_name == 'pull_request' && secrets.ORG_ADMIN_TOKEN != ''
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
env:
ORG_ADMIN_TOKEN: ${{ secrets.ORG_ADMIN_TOKEN }}

permissions:
contents: read
Expand All @@ -51,11 +53,12 @@ jobs:
run: npm ci

- name: Dry run
if: env.ORG_ADMIN_TOKEN != ''
working-directory: .github/scripts
run: node sync-dashboard-team.js
env:
DRY_RUN: true
GITHUB_TOKEN: ${{ secrets.ORG_ADMIN_TOKEN }}
GITHUB_TOKEN: ${{ env.ORG_ADMIN_TOKEN }}
ORG: kernelci
TEAM_SLUG: dashboard

Expand Down
Loading