feat: Added share vex / sbom option to the share your ... modal#725
Conversation
There was a problem hiding this comment.
Pull request overview
Adds public SBOM/VEX sharing controls directly to the download modals, tying them to the existing asset-level sharing setting.
Changes:
- Adds public URL display/copy UI and sharing toggles to the SBOM and VEX download modals.
- Patches the asset
sharesInformationsetting from those modals. - Syncs the settings form field when
asset.sharesInformationchanges.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
src/components/dependencies/VexDownloadModal.tsx |
Adds public VEX URL display, copy action, and public sharing toggle. |
src/components/dependencies/SbomDownloadModal.tsx |
Adds public SBOM URL display, copy action, and public sharing toggle. |
src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/page.tsx |
Syncs the settings form’s sharesInformation field from the active asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| : ""; | ||
|
|
||
| return ( | ||
| <div className="pl-4"> |
There was a problem hiding this comment.
This right here makes it hard to maintain. A component should not style itself because it gets used by a parent component where that style would fit great. So basically the parent component should use this one and add the pl-4, either by wrapping it in a div or providing a className prop
Maybe even move the different components and hooks into their dedicated functions.
l3montree-dev/devguard#1922