Skip to content

feat: Added share vex / sbom option to the share your ... modal#725

Merged
timbastin merged 3 commits into
mainfrom
share/vex/sbom
May 19, 2026
Merged

feat: Added share vex / sbom option to the share your ... modal#725
timbastin merged 3 commits into
mainfrom
share/vex/sbom

Conversation

@juliankepka
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds public SBOM/VEX sharing controls directly to the download modals, tying them to the existing asset-level sharing setting.

Changes:

  • Adds public URL display/copy UI and sharing toggles to the SBOM and VEX download modals.
  • Patches the asset sharesInformation setting from those modals.
  • Syncs the settings form field when asset.sharesInformation changes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.

File Description
src/components/dependencies/VexDownloadModal.tsx Adds public VEX URL display, copy action, and public sharing toggle.
src/components/dependencies/SbomDownloadModal.tsx Adds public SBOM URL display, copy action, and public sharing toggle.
src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/page.tsx Syncs the settings form’s sharesInformation field from the active asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/dependencies/VexDownloadModal.tsx Outdated
Comment thread src/components/dependencies/SbomDownloadModal.tsx Outdated
Comment thread src/components/dependencies/VexDownloadModal.tsx Outdated
Comment thread src/components/dependencies/SbomDownloadModal.tsx Outdated
Comment thread src/components/dependencies/SbomDownloadModal.tsx Outdated
Comment thread src/components/dependencies/SbomDownloadModal.tsx Outdated
Comment thread src/components/dependencies/VexDownloadModal.tsx Outdated
Comment thread src/components/dependencies/VexDownloadModal.tsx Outdated
Comment thread src/components/dependencies/SbomDownloadModal.tsx Outdated
: "";

return (
<div className="pl-4">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This right here makes it hard to maintain. A component should not style itself because it gets used by a parent component where that style would fit great. So basically the parent component should use this one and add the pl-4, either by wrapping it in a div or providing a className prop

Maybe even move the different components and hooks into their dedicated functions.

@timbastin timbastin merged commit 6a1e9fc into main May 19, 2026
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants