feat: enhance Windows notification handling with Git Bash support

Author: qorzj

packages/core/src/common/notify.ts

@@ -1,4 +1,5 @@
 import { spawn, type SpawnOptions } from "child_process";
+import { findGitBashPath, windowsPathToPosixPath } from "./shell-utils";
 
 type NotifyChildProcess = {
   once(event: "error", listener: (error: NodeJS.ErrnoException) => void): NotifyChildProcess;
@@ -8,7 +9,7 @@ type NotifyChildProcess = {
 export type NotifySpawn = (
   command: string,
   args: string[],
-  options: Pick<SpawnOptions, "cwd" | "detached" | "env" | "stdio">
+  options: Pick<SpawnOptions, "cwd" | "detached" | "env" | "stdio" | "windowsHide">
 ) => NotifyChildProcess;
 
 export function formatDurationSeconds(durationMs: number): string {
@@ -58,24 +59,37 @@ export function launchNotifyScript(
   workingDirectory?: string,
   spawnProcess: NotifySpawn = spawn as unknown as NotifySpawn,
   configuredEnv: Record<string, string> = {},
-  context: NotifyContext = {}
+  context: NotifyContext = {},
+  runtime: { platform: NodeJS.Platform; findGitBashPath: () => string } = {
+    platform: process.platform,
+    findGitBashPath,
+  }
 ): void {
   const commandPath = notifyPath?.trim();
   if (!commandPath) {
     return;
   }
 
+  const isWindows = runtime.platform === "win32";
   const options = {
     cwd: workingDirectory,
-    detached: process.platform !== "win32",
+    detached: !isWindows,
     env: buildNotifyEnv(durationMs, { ...process.env, ...configuredEnv }, context),
     stdio: "ignore" as const,
+    ...(isWindows ? { windowsHide: true } : {}),
   };
 
   try {
-    const child = spawnProcess(commandPath, [], options);
+    const useGitBash = isWindows && /\.sh$/i.test(commandPath);
+    const child = useGitBash
+      ? spawnProcess(
+          runtime.findGitBashPath(),
+          ["--noprofile", "--norc", "--", windowsPathToPosixPath(commandPath)],
+          options
+        )
+      : spawnProcess(commandPath, [], options);
     child.once("error", (error) => {
-      if (process.platform === "win32") {
+      if (isWindows) {
         return;
       }
       if (error.code !== "EACCES" && error.code !== "ENOEXEC") {

packages/core/src/tests/notify-windows.test.ts

@@ -0,0 +1,137 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { launchNotifyScript, type NotifySpawn } from "../common/notify";
+
+const bashPath = "C:\\Program Files\\Git\\bin\\bash.exe";
+const runtime = { platform: "win32" as const, findGitBashPath: () => bashPath };
+
+function captureSpawn(errorCode?: string) {
+  const calls: Parameters<NotifySpawn>[] = [];
+  let unrefs = 0;
+  const spawn: NotifySpawn = (...args) => {
+    calls.push(args);
+    return {
+      once(_event, listener) {
+        if (errorCode) listener({ code: errorCode } as NodeJS.ErrnoException);
+        return this;
+      },
+      unref() {
+        unrefs++;
+      },
+    };
+  };
+  return { calls, spawn, unrefs: () => unrefs };
+}
+
+test("Windows shell notifications pass the script as one Git Bash argument and preserve context", () => {
+  const paths = [
+    ["C:\\Users\\张 三\\O'Brien & $(echo test)\\notify.sh", "/c/Users/张 三/O'Brien & $(echo test)/notify.sh"],
+    ["D:/通知 文件/notify.SH", "/d/通知 文件/notify.SH"],
+    ["/c/Users/you/notify.sh", "/c/Users/you/notify.sh"],
+    ["\\\\server\\share\\通知 文件\\notify.sh", "//server/share/通知 文件/notify.sh"],
+  ];
+  for (const [script, bashScript] of paths) {
+    const capture = captureSpawn();
+    launchNotifyScript(
+      `  ${script}  `,
+      15999,
+      "C:\\project",
+      capture.spawn,
+      { NOTIFY_CUSTOM: "value" },
+      { status: "failed", failReason: "error", body: "a\nb", title: "test" },
+      runtime
+    );
+    assert.equal(capture.calls.length, 1);
+    const [command, args, options] = capture.calls[0];
+    assert.equal(command, bashPath);
+    assert.deepEqual(args, ["--noprofile", "--norc", "--", bashScript]);
+    assert.equal(options.cwd, "C:\\project");
+    assert.equal(options.detached, false);
+    assert.equal(options.windowsHide, true);
+    assert.equal(options.stdio, "ignore");
+    assert.equal(options.env?.NOTIFY_CUSTOM, "value");
+    assert.equal(options.env?.DURATION, "15");
+    assert.equal(options.env?.STATUS, "failed");
+    assert.equal(options.env?.FAIL_REASON, "error");
+    assert.equal(options.env?.BODY, "a\nb");
+    assert.equal(options.env?.TITLE, "test");
+    assert.equal(capture.unrefs(), 1);
+  }
+});
+
+test("Windows non-shell notifications retain direct execution", () => {
+  for (const script of ["C:\\notify.exe", "C:\\notify.py", "C:\\notify.cmd"]) {
+    const capture = captureSpawn();
+    launchNotifyScript(
+      script,
+      0,
+      undefined,
+      capture.spawn,
+      {},
+      {},
+      {
+        platform: "win32",
+        findGitBashPath: () => {
+          assert.fail("Non-shell notifications must not look up Git Bash");
+        },
+      }
+    );
+    assert.equal(capture.calls.length, 1);
+    assert.equal(capture.calls[0][0], script);
+    assert.deepEqual(capture.calls[0][1], []);
+  }
+});
+
+test("Windows notification lookup and spawn failures do not escape or start a fallback shell", () => {
+  const capture = captureSpawn();
+  assert.doesNotThrow(() =>
+    launchNotifyScript(
+      "C:\\notify.sh",
+      0,
+      undefined,
+      capture.spawn,
+      {},
+      {},
+      {
+        platform: "win32",
+        findGitBashPath: () => {
+          throw new Error("Git Bash not found");
+        },
+      }
+    )
+  );
+  assert.equal(capture.calls.length, 0);
+
+  const throwingSpawn: NotifySpawn = () => {
+    throw new Error("spawn failed");
+  };
+  assert.doesNotThrow(() => launchNotifyScript("C:\\notify.sh", 0, undefined, throwingSpawn, {}, {}, runtime));
+
+  for (const code of ["ENOENT", "EACCES", "ENOEXEC"]) {
+    const failed = captureSpawn(code);
+    assert.doesNotThrow(() => launchNotifyScript("C:\\notify.sh", 0, undefined, failed.spawn, {}, {}, runtime));
+    assert.equal(failed.calls.length, 1);
+    assert.equal(failed.unrefs(), 1);
+  }
+});
+
+test("empty notification paths do not look up Git Bash or spawn a process", () => {
+  const capture = captureSpawn();
+  for (const script of [undefined, "", "  "]) {
+    launchNotifyScript(
+      script,
+      0,
+      undefined,
+      capture.spawn,
+      {},
+      {},
+      {
+        platform: "win32",
+        findGitBashPath: () => {
+          assert.fail("Empty paths must not look up Git Bash");
+        },
+      }
+    );
+  }
+  assert.equal(capture.calls.length, 0);
+});