Remove nextest to speed up CI#227
Merged
Merged
Conversation
…ss (`cargo nextest` didn't support doctests)
LaurenzV
approved these changes
May 23, 2026
Comment on lines
+219
to
+220
| - name: cargo test | ||
| run: cargo test --workspace --locked --all-features --no-fail-fast --target ${{ matrix.platform.target }} |
Collaborator
There was a problem hiding this comment.
Are you sure this will test the docs? Since this was removed.
Contributor
Author
There was a problem hiding this comment.
Yes, Cargo runs doctests by default. You can verify that by e.g. running cargo test under Address Sanitizer and watch them fail to link.
| --config 'target.wasm32-wasip1.runner = "wasmtime"' | ||
|
|
||
| - name: cargo test --doc | ||
| - name: cargo test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo nextest's claim to fame is faster performance in some cases. However, its model of one process per test maps especially poorly tofearless_simdtest structure.We have over a thousand very small tests, so process spawning overhead really adds up. Locally
cargo testis 4x faster thancargo nexteston my x86 machine.cargo nextestoverhead gets particularly egregious for WASM tests, where it starts up a whole new instance ofwasmtimefor every single test, which adds up to over 3 minutes to run the test suite even on my beefy machine.cargo testcompletes in just a few seconds.