PoC: x86 CPU levels behind feature flags#228
Draft
Shnatsel wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex-driven sketch of what it would take to put x86 CPU levels behind Cargo feature flags. It's not as bad as I feared.
Part of #92
SSE4.2 and AVX2 are now independent Cargo features, enabled by default.
Key changes:
sse4_2andavx2features inCargo.toml.generated.rs.Levelvariants, detection,baseline, accessors, and dispatch arms inlib.rsandmacros.rs.#[cfg(feature = ...)].kernel!soSse4_2/Avx2token kernels require the matching crate feature.#[cfg(not(feature = "sse4_2"))]vialevel.rsandmk_x86.rs.Verification passed:
cargo check -p fearless_simdacross default,std,std,avx2,std,sse4_2,--all-featuresRUSTFLAGS='-Ctarget-cpu=x86-64-v3'cargo clippy -p fearless_simd ... -- -D warningsacross default, all-features, fallback-only, AVX2-only, SSE-onlycargo test -p fearless_simd --libcargo test -p fearless_simd --lib --no-default-features --features stdcargo test -p fearless_simd_testsdispatch!with dependency featuresstd,std,avx2, andstd,sse4_2No broad dead-code suppression was needed.