You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a AbstractAnonymizer::__construct() signature change, which means a breaking change.
The PR will be huge, there are many places to fix (especially unit tests).
Another question remains: could we actually allow this breaking change to be in a minor version? My opinion is yes, because people extending the AbstractAnonymizer class or any of the existing subclass are likely not needing to change the constructor implementation, and they don't instanciate their code themselves since it's the role of the AnonymizerRegistry class.
Followup of #226.
The idea is to propagate
AnonymizerConfigdirectly toAbstractAnonymizerconstructor, instead of de-structuring it as$tableand$columnparameters.This has many advantages:
AnonyizerConfigthenAbstractAnonymizer::__construct()will remain stable (no refactoring needed).AnonyizerConfigproperties, and thus gain flexibility.base pathinformation from fix #226 - base path in AnonymiationConfig and related documentation #232 to load data files.Disadvantages:
AbstractAnonymizer::__construct()signature change, which means a breaking change.Another question remains: could we actually allow this breaking change to be in a minor version? My opinion is yes, because people extending the
AbstractAnonymizerclass or any of the existing subclass are likely not needing to change the constructor implementation, and they don't instanciate their code themselves since it's the role of theAnonymizerRegistryclass.