From 895f833991bac867e4906ba920e9c04b548cdb47 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Wed, 4 Nov 2026 16:46:35 -0800 Subject: [PATCH 1/2] programs: mark the LDM and overlap globals used in decompress-only builds A newer clang flags -Wunused-but-set-global on g_overlapLog and the g_ldm* globals in the decompress-only zstd-decompress build: they are set while parsing arguments, but only read by the benchmark and compression code, which ZSTD_NOBENCH and ZSTD_NOCOMPRESS compile out. With -Werror, this breaks the mingw-short-test (clang) CI job on every PR since the MSYS2 clang update. List them with the other compression-only variables in the ZSTD_NOCOMPRESS branch of main(). --- programs/zstdcli.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/programs/zstdcli.c b/programs/zstdcli.c index 31b06d67be5..d0821db9741 100644 --- a/programs/zstdcli.c +++ b/programs/zstdcli.c @@ -1668,6 +1668,8 @@ int main(int argCount, const char* argv[]) (void)ultra; (void)cLevel; (void)ldmFlag; (void)literalCompressionMode; (void)targetCBlockSize; (void)streamSrcSize; (void)srcSizeHint; (void)ZSTD_strategyMap; (void)useRowMatchFinder; (void)cType; + (void)g_overlapLog; (void)g_ldmHashLog; (void)g_ldmMinMatch; + (void)g_ldmHashRateLog; (void)g_ldmBucketSizeLog; DISPLAYLEVEL(1, "Compression not supported \n"); #endif } else { /* decompression or test */ From 701009d8488150c23d2e27259dca1ff2fbb1a370 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Mon, 5 Oct 2026 18:11:43 -0700 Subject: [PATCH 2/2] ci: refresh job duration comments in dev-long-tests Measured on #4825: make-test, make-test-macos, no-intrinsics-fuzztest, tsan-fuzztest and gcc-8-asan-ubsan-testzstd are faster since. oss-fuzz's comment was already stale, at 13-17 min. --- .github/workflows/dev-long-tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/dev-long-tests.yml b/.github/workflows/dev-long-tests.yml index fab0b96203f..dcdb5674c00 100644 --- a/.github/workflows/dev-long-tests.yml +++ b/.github/workflows/dev-long-tests.yml @@ -20,7 +20,7 @@ jobs: - name: make all run: make all - # lasts ~19mn + # lasts ~8mn make-test: runs-on: ubuntu-latest env: @@ -34,7 +34,7 @@ jobs: make -j zstd ./tests/test_process_substitution.bash ./zstd - # lasts ~16mn + # lasts ~9mn make-test-macos: runs-on: macos-latest steps: @@ -66,7 +66,7 @@ jobs: run: | CFLAGS="-Werror -O3" make -j -C tests test-largeDictionary - # lasts ~9mn + # lasts ~4mn no-intrinsics-fuzztest: runs-on: ubuntu-latest steps: @@ -89,7 +89,7 @@ jobs: - name: ub + address sanitizer on zstreamtest run: CC=clang make uasan-test-zstream - # lasts ~11mn + # lasts ~5mn tsan-fuzztest: runs-on: ubuntu-latest steps: @@ -107,7 +107,7 @@ jobs: make libc6install CC=clang make -C tests test-zstream32 FUZZER_FLAGS="--big-tests" - # lasts ~13mn + # lasts ~8mn gcc-8-asan-ubsan-testzstd: runs-on: ubuntu-latest steps: @@ -308,7 +308,7 @@ jobs: $CXX --version make -C tests fuzztest - # lasts ~20mn + # lasts ~14mn oss-fuzz: runs-on: ubuntu-latest strategy: