From da236253c8d60de4ab7810f83d8eae5e1d289e64 Mon Sep 17 00:00:00 2001 From: James Chapman Date: Mon, 8 Jun 2026 10:43:06 +0000 Subject: [PATCH 01/10] BUG FIXES: * Health check can falsely return OK even if Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) --- CHANGELOG.md | 3 ++ api_app/_version.py | 2 +- api_app/services/health_checker.py | 3 +- .../test_services/test_health_checker.py | 34 +++++++++++++++++++ 4 files changed, 40 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f99328b247..74d13b56b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,9 @@ ENHANCEMENTS: * Pin all GitHub Actions workflow steps to full commit SHAs to prevent supply chain attacks plus update to latest releases ([#4886](https://github.com/microsoft/AzureTRE/pull/4886)) * Add Windows Server 2025 image support to Guacamole. ([#4890](https://github.com/microsoft/AzureTRE/issues/4890)) +BUG FIXES: +* Health check can falsely return OK even if Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) + ## (0.28.0) (March 2, 2026) **BREAKING CHANGES** * Sonatype Nexus shared service now requires explicit EULA acceptance (`accept_nexus_eula: true`) when deploying. This ensures compliance with Sonatype Nexus Community Edition licensing. ([#4842](https://github.com/microsoft/AzureTRE/issues/4842)) diff --git a/api_app/_version.py b/api_app/_version.py index 7923a95d33..57a322dfc2 100644 --- a/api_app/_version.py +++ b/api_app/_version.py @@ -1 +1 @@ -__version__ = "0.25.16" +__version__ = "0.25.17" diff --git a/api_app/services/health_checker.py b/api_app/services/health_checker.py index a4d53067b0..34139e4df9 100644 --- a/api_app/services/health_checker.py +++ b/api_app/services/health_checker.py @@ -19,7 +19,8 @@ async def create_state_store_status() -> Tuple[StatusEnum, str]: message = "" try: container: ContainerProxy = await Database().get_container_proxy(STATE_STORE_RESOURCES_CONTAINER) - container.query_items("SELECT TOP 1 * FROM c") + async for _ in container.query_items("SELECT TOP 1 * FROM c", max_item_count=1): + break except exceptions.ServiceRequestError: status = StatusEnum.not_ok message = strings.STATE_STORE_ENDPOINT_NOT_RESPONDING diff --git a/api_app/tests_ma/test_services/test_health_checker.py b/api_app/tests_ma/test_services/test_health_checker.py index 6b1d955f89..396ac197e4 100644 --- a/api_app/tests_ma/test_services/test_health_checker.py +++ b/api_app/tests_ma/test_services/test_health_checker.py @@ -2,6 +2,7 @@ from unittest.mock import AsyncMock, MagicMock import pytest from azure.core.exceptions import ServiceRequestError +from azure.cosmos.exceptions import CosmosHttpResponseError from azure.servicebus.exceptions import ServiceBusConnectionError from mock import patch from models.schemas.status import StatusEnum @@ -39,6 +40,39 @@ async def test_get_state_store_status_other_exception(container_proxy_mock) -> N assert message == strings.UNSPECIFIED_ERROR +class AsyncIteratorWithError: + def __init__(self, exception): + self.exception = exception + + def __aiter__(self): + return self + + async def __anext__(self): + raise self.exception + + +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_cosmos_http_error(get_container_proxy_mock) -> None: + container_mock = MagicMock() + container_mock.query_items.return_value = AsyncIteratorWithError(CosmosHttpResponseError(message="some message")) + get_container_proxy_mock.return_value = container_mock + status, message = await health_checker.create_state_store_status() + + assert status == StatusEnum.not_ok + assert message == strings.STATE_STORE_ENDPOINT_NOT_ACCESSIBLE + + +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_service_request_error(get_container_proxy_mock) -> None: + container_mock = MagicMock() + container_mock.query_items.return_value = AsyncIteratorWithError(ServiceRequestError(message="some message")) + get_container_proxy_mock.return_value = container_mock + status, message = await health_checker.create_state_store_status() + + assert status == StatusEnum.not_ok + assert message == strings.STATE_STORE_ENDPOINT_NOT_RESPONDING + + @patch("core.credentials.get_credential_async_context") @patch("services.health_checker.ServiceBusClient") async def test_get_service_bus_status_responding(service_bus_client_mock, get_credential_async_context) -> None: From 0836ed6f99111eebde942e4e0fc911e57bb83e1b Mon Sep 17 00:00:00 2001 From: James Chapman Date: Mon, 8 Jun 2026 10:52:53 +0000 Subject: [PATCH 02/10] =?UTF-8?q?Updated=20test=5Fhealth=5Fchecker.py=20in?= =?UTF-8?q?=20=20test=5Fhealth=5Fchecker.py=20=20to=20patch=20api.dependen?= =?UTF-8?q?cies.database.Database.=20=20=20get=5Fcontainer=5Fproxy=20=20in?= =?UTF-8?q?stead=20of=20=20azure.cosmos.aio.ContainerProxy.query=5Fitems?= =?UTF-8?q?=20.=20=20=20=E2=80=A2=20Configured=20the=20return=20value=20of?= =?UTF-8?q?=20=20get=5Fcontainer=5Fproxy=5Fmock=20=20to=20be=20a=20mock=20?= =?UTF-8?q?container=20whose=20=20=20query=5Fitems=20=20function=20returns?= =?UTF-8?q?=20a=20real=20async=20iterator:=20=20AsyncIterator([{"id":=20"i?= =?UTF-8?q?tem"}])=20.=20=20=20=E2=80=A2=20Verified=20that=20all=20unit=20?= =?UTF-8?q?tests=20pass,=20and=20successfully=20ran=20the=20entire=20test?= =?UTF-8?q?=20suite=20(all=20675=20tests=20=20=20passed).?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- api_app/tests_ma/test_services/test_health_checker.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/api_app/tests_ma/test_services/test_health_checker.py b/api_app/tests_ma/test_services/test_health_checker.py index 396ac197e4..5b62376fef 100644 --- a/api_app/tests_ma/test_services/test_health_checker.py +++ b/api_app/tests_ma/test_services/test_health_checker.py @@ -12,8 +12,11 @@ pytestmark = pytest.mark.asyncio -@patch("azure.cosmos.aio.ContainerProxy.query_items", return_value=AsyncMock()) -async def test_get_state_store_status_responding(_) -> None: +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_responding(get_container_proxy_mock) -> None: + container_mock = MagicMock() + container_mock.query_items.return_value = AsyncIterator([{"id": "item"}]) + get_container_proxy_mock.return_value = container_mock status, message = await health_checker.create_state_store_status() assert status == StatusEnum.ok From 8541ce252ec3aa4aeb78c0d4572ec16b9a14ac64 Mon Sep 17 00:00:00 2001 From: James Chapman Date: Mon, 8 Jun 2026 10:59:27 +0000 Subject: [PATCH 03/10] changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74d13b56b2..6d5ad8f747 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ ENHANCEMENTS: * Add Windows Server 2025 image support to Guacamole. ([#4890](https://github.com/microsoft/AzureTRE/issues/4890)) BUG FIXES: -* Health check can falsely return OK even if Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) +* Fix Health check can falsely return OK even if Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) ## (0.28.0) (March 2, 2026) **BREAKING CHANGES** From 863898371666f147c37b2fa34892352ac97593e0 Mon Sep 17 00:00:00 2001 From: James Chapman Date: Mon, 6 Jul 2026 09:33:25 +0000 Subject: [PATCH 04/10] version --- api_app/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api_app/_version.py b/api_app/_version.py index eda2a21a48..7df7ad28da 100644 --- a/api_app/_version.py +++ b/api_app/_version.py @@ -1 +1 @@ -__version__ = "0.25.26" +__version__ = "0.25.27" From 0009c906b863735ba94f75601f4c3aa2d0e5ebc2 Mon Sep 17 00:00:00 2001 From: James Chapman Date: Mon, 6 Jul 2026 10:19:56 +0000 Subject: [PATCH 05/10] opus feedback --- api_app/services/health_checker.py | 1 + .../test_services/test_health_checker.py | 74 +++++++++++++++---- 2 files changed, 62 insertions(+), 13 deletions(-) diff --git a/api_app/services/health_checker.py b/api_app/services/health_checker.py index 34139e4df9..2d99500988 100644 --- a/api_app/services/health_checker.py +++ b/api_app/services/health_checker.py @@ -19,6 +19,7 @@ async def create_state_store_status() -> Tuple[StatusEnum, str]: message = "" try: container: ContainerProxy = await Database().get_container_proxy(STATE_STORE_RESOURCES_CONTAINER) + await container.read() async for _ in container.query_items("SELECT TOP 1 * FROM c", max_item_count=1): break except exceptions.ServiceRequestError: diff --git a/api_app/tests_ma/test_services/test_health_checker.py b/api_app/tests_ma/test_services/test_health_checker.py index 5b62376fef..fa86d7dd88 100644 --- a/api_app/tests_ma/test_services/test_health_checker.py +++ b/api_app/tests_ma/test_services/test_health_checker.py @@ -12,15 +12,48 @@ pytestmark = pytest.mark.asyncio +def create_mock_container(query_results=None, query_error=None, read_error=None): + container_mock = MagicMock() + + # Mock read() + if read_error: + container_mock.read = AsyncMock(side_effect=read_error) + else: + container_mock.read = AsyncMock(return_value={"id": "container_properties"}) + + # Mock query_items() + query_items_mock = MagicMock() + if query_error: + query_items_mock.return_value.__aiter__.side_effect = query_error + else: + query_items_mock.return_value.__aiter__.return_value = query_results or [] + + container_mock.query_items = query_items_mock + return container_mock + + @patch("api.dependencies.database.Database.get_container_proxy") async def test_get_state_store_status_responding(get_container_proxy_mock) -> None: - container_mock = MagicMock() - container_mock.query_items.return_value = AsyncIterator([{"id": "item"}]) + container_mock = create_mock_container(query_results=[{"id": "item"}]) + get_container_proxy_mock.return_value = container_mock + status, message = await health_checker.create_state_store_status() + + assert status == StatusEnum.ok + assert message == "" + container_mock.read.assert_called_once() + container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) + + +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_empty_results(get_container_proxy_mock) -> None: + container_mock = create_mock_container(query_results=[]) get_container_proxy_mock.return_value = container_mock status, message = await health_checker.create_state_store_status() assert status == StatusEnum.ok assert message == "" + container_mock.read.assert_called_once() + container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) @patch("api.dependencies.database.Database.get_container_proxy") @@ -43,37 +76,52 @@ async def test_get_state_store_status_other_exception(container_proxy_mock) -> N assert message == strings.UNSPECIFIED_ERROR -class AsyncIteratorWithError: - def __init__(self, exception): - self.exception = exception +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_read_cosmos_http_error(get_container_proxy_mock) -> None: + container_mock = create_mock_container(read_error=CosmosHttpResponseError(message="some message")) + get_container_proxy_mock.return_value = container_mock + status, message = await health_checker.create_state_store_status() + + assert status == StatusEnum.not_ok + assert message == strings.STATE_STORE_ENDPOINT_NOT_ACCESSIBLE + container_mock.read.assert_called_once() + container_mock.query_items.assert_not_called() - def __aiter__(self): - return self - async def __anext__(self): - raise self.exception +@patch("api.dependencies.database.Database.get_container_proxy") +async def test_get_state_store_status_read_service_request_error(get_container_proxy_mock) -> None: + container_mock = create_mock_container(read_error=ServiceRequestError(message="some message")) + get_container_proxy_mock.return_value = container_mock + status, message = await health_checker.create_state_store_status() + + assert status == StatusEnum.not_ok + assert message == strings.STATE_STORE_ENDPOINT_NOT_RESPONDING + container_mock.read.assert_called_once() + container_mock.query_items.assert_not_called() @patch("api.dependencies.database.Database.get_container_proxy") async def test_get_state_store_status_cosmos_http_error(get_container_proxy_mock) -> None: - container_mock = MagicMock() - container_mock.query_items.return_value = AsyncIteratorWithError(CosmosHttpResponseError(message="some message")) + container_mock = create_mock_container(query_error=CosmosHttpResponseError(message="some message")) get_container_proxy_mock.return_value = container_mock status, message = await health_checker.create_state_store_status() assert status == StatusEnum.not_ok assert message == strings.STATE_STORE_ENDPOINT_NOT_ACCESSIBLE + container_mock.read.assert_called_once() + container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) @patch("api.dependencies.database.Database.get_container_proxy") async def test_get_state_store_status_service_request_error(get_container_proxy_mock) -> None: - container_mock = MagicMock() - container_mock.query_items.return_value = AsyncIteratorWithError(ServiceRequestError(message="some message")) + container_mock = create_mock_container(query_error=ServiceRequestError(message="some message")) get_container_proxy_mock.return_value = container_mock status, message = await health_checker.create_state_store_status() assert status == StatusEnum.not_ok assert message == strings.STATE_STORE_ENDPOINT_NOT_RESPONDING + container_mock.read.assert_called_once() + container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) @patch("core.credentials.get_credential_async_context") From 1eeda8d4abb1dd3a2d2cf6eed7d27807e6a3783b Mon Sep 17 00:00:00 2001 From: James Chapman Date: Tue, 21 Jul 2026 10:52:26 +0000 Subject: [PATCH 06/10] revert additional container read --- api_app/services/health_checker.py | 3 +- .../test_services/test_health_checker.py | 44 +++---------------- 2 files changed, 6 insertions(+), 41 deletions(-) diff --git a/api_app/services/health_checker.py b/api_app/services/health_checker.py index 2d99500988..4a4340c9fa 100644 --- a/api_app/services/health_checker.py +++ b/api_app/services/health_checker.py @@ -19,8 +19,7 @@ async def create_state_store_status() -> Tuple[StatusEnum, str]: message = "" try: container: ContainerProxy = await Database().get_container_proxy(STATE_STORE_RESOURCES_CONTAINER) - await container.read() - async for _ in container.query_items("SELECT TOP 1 * FROM c", max_item_count=1): + async for _ in container.query_items("SELECT TOP 1 VALUE 1 FROM c", max_item_count=1): break except exceptions.ServiceRequestError: status = StatusEnum.not_ok diff --git a/api_app/tests_ma/test_services/test_health_checker.py b/api_app/tests_ma/test_services/test_health_checker.py index fa86d7dd88..8d9d23a700 100644 --- a/api_app/tests_ma/test_services/test_health_checker.py +++ b/api_app/tests_ma/test_services/test_health_checker.py @@ -12,15 +12,9 @@ pytestmark = pytest.mark.asyncio -def create_mock_container(query_results=None, query_error=None, read_error=None): +def create_mock_container(query_results=None, query_error=None): container_mock = MagicMock() - # Mock read() - if read_error: - container_mock.read = AsyncMock(side_effect=read_error) - else: - container_mock.read = AsyncMock(return_value={"id": "container_properties"}) - # Mock query_items() query_items_mock = MagicMock() if query_error: @@ -40,8 +34,7 @@ async def test_get_state_store_status_responding(get_container_proxy_mock) -> No assert status == StatusEnum.ok assert message == "" - container_mock.read.assert_called_once() - container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) + container_mock.query_items.assert_called_once_with("SELECT TOP 1 VALUE 1 FROM c", max_item_count=1) @patch("api.dependencies.database.Database.get_container_proxy") @@ -52,8 +45,7 @@ async def test_get_state_store_status_empty_results(get_container_proxy_mock) -> assert status == StatusEnum.ok assert message == "" - container_mock.read.assert_called_once() - container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) + container_mock.query_items.assert_called_once_with("SELECT TOP 1 VALUE 1 FROM c", max_item_count=1) @patch("api.dependencies.database.Database.get_container_proxy") @@ -76,30 +68,6 @@ async def test_get_state_store_status_other_exception(container_proxy_mock) -> N assert message == strings.UNSPECIFIED_ERROR -@patch("api.dependencies.database.Database.get_container_proxy") -async def test_get_state_store_status_read_cosmos_http_error(get_container_proxy_mock) -> None: - container_mock = create_mock_container(read_error=CosmosHttpResponseError(message="some message")) - get_container_proxy_mock.return_value = container_mock - status, message = await health_checker.create_state_store_status() - - assert status == StatusEnum.not_ok - assert message == strings.STATE_STORE_ENDPOINT_NOT_ACCESSIBLE - container_mock.read.assert_called_once() - container_mock.query_items.assert_not_called() - - -@patch("api.dependencies.database.Database.get_container_proxy") -async def test_get_state_store_status_read_service_request_error(get_container_proxy_mock) -> None: - container_mock = create_mock_container(read_error=ServiceRequestError(message="some message")) - get_container_proxy_mock.return_value = container_mock - status, message = await health_checker.create_state_store_status() - - assert status == StatusEnum.not_ok - assert message == strings.STATE_STORE_ENDPOINT_NOT_RESPONDING - container_mock.read.assert_called_once() - container_mock.query_items.assert_not_called() - - @patch("api.dependencies.database.Database.get_container_proxy") async def test_get_state_store_status_cosmos_http_error(get_container_proxy_mock) -> None: container_mock = create_mock_container(query_error=CosmosHttpResponseError(message="some message")) @@ -108,8 +76,7 @@ async def test_get_state_store_status_cosmos_http_error(get_container_proxy_mock assert status == StatusEnum.not_ok assert message == strings.STATE_STORE_ENDPOINT_NOT_ACCESSIBLE - container_mock.read.assert_called_once() - container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) + container_mock.query_items.assert_called_once_with("SELECT TOP 1 VALUE 1 FROM c", max_item_count=1) @patch("api.dependencies.database.Database.get_container_proxy") @@ -120,8 +87,7 @@ async def test_get_state_store_status_service_request_error(get_container_proxy_ assert status == StatusEnum.not_ok assert message == strings.STATE_STORE_ENDPOINT_NOT_RESPONDING - container_mock.read.assert_called_once() - container_mock.query_items.assert_called_once_with("SELECT TOP 1 * FROM c", max_item_count=1) + container_mock.query_items.assert_called_once_with("SELECT TOP 1 VALUE 1 FROM c", max_item_count=1) @patch("core.credentials.get_credential_async_context") From 11ab4c0d4d2ea1bfeecc1ce40ffa3d821a43a33b Mon Sep 17 00:00:00 2001 From: James Chapman Date: Thu, 23 Jul 2026 12:12:46 +0000 Subject: [PATCH 07/10] version --- api_app/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api_app/_version.py b/api_app/_version.py index 605b3cd20e..5a30a412a8 100644 --- a/api_app/_version.py +++ b/api_app/_version.py @@ -1 +1 @@ -__version__ = "0.25.29" +__version__ = "0.25.30" From 796cd68666be28affe251d98079b7bb9ec8dfd7d Mon Sep 17 00:00:00 2001 From: James Chapman <196318169+JC-wk@users.noreply.github.com> Date: Fri, 4 Sep 2026 22:33:47 +0100 Subject: [PATCH 08/10] Fix health check false positive for Cosmos status Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 529b4ca5a8..83627cd999 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ ENHANCEMENTS: BUG FIXES: * Configure the default pytest-asyncio fixture loop scope to `function` to remove the deprecation warning. ([#5055](https://github.com/microsoft/AzureTRE/pull/5055)) * Fix inconsistent ServiceBusClient lifecycle management in deployment_status_updater.py, airlock_request_status_update.py, and runner.py to prevent connection socket and AMQP channel leaks ([#4930](https://github.com/microsoft/AzureTRE/pull/4930)) -* Fix Health check can falsely return OK even if Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) +* Fix the health check falsely returning OK when Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) ## (0.29.0) (August 14, 2026) **BREAKING CHANGES** From 991aa84b61e400856b21334e29e773201b3135bd Mon Sep 17 00:00:00 2001 From: James Chapman Date: Fri, 11 Sep 2026 15:49:08 +0000 Subject: [PATCH 09/10] bump version --- api_app/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api_app/_version.py b/api_app/_version.py index 5252f582fe..29dd6604f8 100644 --- a/api_app/_version.py +++ b/api_app/_version.py @@ -1 +1 @@ -__version__ = "0.26.9" +__version__ = "0.26.10" From bdb889d742e48dc0a5619021f4e6897cc8fbbbfa Mon Sep 17 00:00:00 2001 From: Chris Chapman Date: Fri, 16 Oct 2026 13:06:47 +0100 Subject: [PATCH 10/10] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa8bcfc5a5..185b571706 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -58,6 +58,7 @@ BUG FIXES: * Fix OHDSI bundle builds by moving to Debian Bookworm and installing a checksum-verified Go `sqlcmd` release. (`tre-workspace-service-ohdsi` 0.3.10) ([#5083](https://github.com/microsoft/AzureTRE/issues/5083)) * Fix Guacamole login failures in large workspaces: raise the user-resources API timeout from 5s to 30s, batch template version lookups into one Cosmos query, and query VM power states concurrently. (`tre-service-guacamole` 0.14.6, `API` 0.27.31) ([#5099](https://github.com/microsoft/AzureTRE/issues/5099)) * Fix API resource update retries so a successful retry returns the patched resource to the original caller. (`API` 0.27.32) ([#5025](https://github.com/microsoft/AzureTRE/pull/5025)) +* Fix the health check falsely returning OK when Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) ## (0.29.1) **BREAKING CHANGES** @@ -97,7 +98,6 @@ BUG FIXES: * Add `bx-msedge.net.` and `vsassets.io.` to the default DNS allowlist. Allow Nexus downloads from `*.gallery.vsassets.io` and `*.gallerycdn.vsassets.io` when DNS security policy is enabled. (`core` 0.16.18, `tre-shared-service-sonatype-nexus` 3.10.3) ([#5071](https://github.com/microsoft/AzureTRE/pull/5071)) * Fix vulnerable GitHub script dependencies with compatible patched versions, add regression tests, and run the helper suite in CI. ([#5064](https://github.com/microsoft/AzureTRE/pull/5064)) * Configure the default pytest-asyncio fixture loop scope to `function` to remove the deprecation warning. ([#5055](https://github.com/microsoft/AzureTRE/pull/5055)) -* Fix the health check falsely returning OK when Cosmos is down or inaccessible. ([#4926](https://github.com/microsoft/AzureTRE/issues/4926)) * Fix pytest deprecation warnings in API test fixtures. ([#5069](https://github.com/microsoft/AzureTRE/pull/5069)) * Fix Service Bus client lifecycle management in the API and resource processor to prevent connection socket and AMQP channel leaks. Close credentials on errors and handle cancellation and retry delays. ([#4930](https://github.com/microsoft/AzureTRE/pull/4930))