From d1726e3ae57457e3bed7e944a5610e93488af0ba Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Thu, 21 May 2026 15:35:58 +0000 Subject: [PATCH] test(disk_usage): assert on error variants with matches! Replace .is_err() with matches!(_, Err(Error::Variant { .. })) in the disk_usage tests and drop the module-level #[expect(clippy::assertions_on_result_states)] override, restoring that lint's coverage. --- src/disk_usage.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/disk_usage.rs b/src/disk_usage.rs index a5977ff..205944d 100644 --- a/src/disk_usage.rs +++ b/src/disk_usage.rs @@ -153,11 +153,6 @@ fn disk_usage(path: &Path) -> Result { #[cfg(test)] mod tests { - #![expect( - clippy::assertions_on_result_states, - reason = "tests intentionally assert on Result variants via is_err()" - )] - use super::*; use std::path::PathBuf; @@ -192,7 +187,7 @@ mod tests { assert_eq!(f64_to_u64(f64::MAX - 1.0)?, u64::MAX); f64_to_u64(0.0)?; - assert!(f64_to_u64(-0.1).is_err()); + assert!(matches!(f64_to_u64(-0.1), Err(Error::U64Conversion { .. }))); assert_eq!(f64_to_u64(EXCESSIVE_VALUE_F64)?, EXCESSIVE_VALUE); // note: testing equality of floating point values is tricky. @@ -217,7 +212,10 @@ mod tests { fn test_check_max_usable() -> Result<()> { check_max_usage(1, TEN)?; check_max_usage(10, TEN)?; - assert!(check_max_usage(11 * 1024 * 1024, TEN).is_err()); + assert!(matches!( + check_max_usage(11 * 1024 * 1024, TEN), + Err(Error::DiskUsageEstimateExceeded { .. }) + )); Ok(()) }