Hey @misode! Thanks for the very handy website :)
While using the advancement generator at
https://misode.github.io/advancement/
I noticed an issue specific to Minecraft 1.20.
Problem
In Minecraft 1.20, if type_specific.type includes the minecraft: namespace, the advancement fails to load.
However, removing the namespace fixes the issue.
Does NOT work (Minecraft 1.20)
{
"criteria": {
"1": {
"trigger": "minecraft:tick",
"conditions": {
"player": [
{
"condition": "minecraft:entity_properties",
"entity": "this",
"predicate": {
"type_specific": {
"type": "minecraft:player"
}
}
}
]
}
}
}
}
Works correctly
{
"criteria": {
"1": {
"trigger": "minecraft:tick",
"conditions": {
"player": [
{
"condition": "minecraft:entity_properties",
"entity": "this",
"predicate": {
"type_specific": {
"type": "player"
}
}
}
]
}
}
}
}
Error message
- Parsing error loading custom advancement ponpon:grant_test:
Not a JSON object:
[{"condition":"minecraft:entity_properties","entity":"this","predicate":{"type_specific":{"type":"minecraft:player","advancements":{"ponpon:granted":true}}}}]
missed input: {"1":{"trigger":"minecraft:tick","conditions":{"player":[{"condition":"minecraft:entity_properties","entity":"this","predicate":{"type_specific":{"type":"minecraft:player","advancements":{"ponpon:granted":true}}}}]}}};
Advancement criteria cannot be empty
Request
Could the generator avoid adding the minecraft: namespace for type_specific.type (at least for 1.20), or warn about this behavior?
Thanks again!
Hey @misode! Thanks for the very handy website :)
While using the advancement generator at
https://misode.github.io/advancement/
I noticed an issue specific to Minecraft 1.20.
Problem
In Minecraft 1.20, if
type_specific.typeincludes theminecraft:namespace, the advancement fails to load.However, removing the namespace fixes the issue.
Does NOT work (Minecraft 1.20)
{ "criteria": { "1": { "trigger": "minecraft:tick", "conditions": { "player": [ { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "type_specific": { "type": "minecraft:player" } } } ] } } } }Works correctly
{ "criteria": { "1": { "trigger": "minecraft:tick", "conditions": { "player": [ { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "type_specific": { "type": "player" } } } ] } } } }Error message
- Parsing error loading custom advancement ponpon:grant_test: Not a JSON object: [{"condition":"minecraft:entity_properties","entity":"this","predicate":{"type_specific":{"type":"minecraft:player","advancements":{"ponpon:granted":true}}}}] missed input: {"1":{"trigger":"minecraft:tick","conditions":{"player":[{"condition":"minecraft:entity_properties","entity":"this","predicate":{"type_specific":{"type":"minecraft:player","advancements":{"ponpon:granted":true}}}}]}}}; Advancement criteria cannot be emptyRequest
Could the generator avoid adding the
minecraft:namespace fortype_specific.type(at least for 1.20), or warn about this behavior?Thanks again!