Skip to content

Commit 57e425c

Browse files
laszlokindratLaszlo Kindrat
andauthored
Fix PR link display on first submit (#114)
Moves the stack display to after PR creation so that PR links are shown correctly on first submission instead of showing "no PR". stack-info: PR: #114, branch: laszlokindrat/stack/2 Co-authored-by: Laszlo Kindrat <laszlo@modular.com>
1 parent 335d615 commit 57e425c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/stack_pr/cli.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1091,7 +1091,6 @@ def command_submit(
10911091
branch_name_template=args.branch_name_template,
10921092
)
10931093
set_base_branches(st, args.target)
1094-
print_stack(st, links=args.hyperlinks)
10951094

10961095
# If the current branch contains commits from the stack, we will need to
10971096
# rebase it in the end since the commits will be modified.
@@ -1114,6 +1113,9 @@ def command_submit(
11141113
# Verify consistency in everything we have so far
11151114
verify(st)
11161115

1116+
# Print stack now that PRs have been created
1117+
print_stack(st, links=args.hyperlinks)
1118+
11171119
# Embed stack-info into commit messages
11181120
log(h("Updating commit messages with stack metadata"), level=2)
11191121
needs_rebase = False

0 commit comments

Comments
 (0)