From 47b2ca575c343ef96a44ac89609135ebc738e8d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Tamarelle?= Date: Fri, 30 Oct 2026 10:20:25 +0100 Subject: [PATCH] PHPC-2791: Add tests for duplicate BSON keys (#2191) --- .../bson-document-duplicate-keys-001.phpt | 27 +++++++ .../bson-document-duplicate-keys-002.phpt | 79 +++++++++++++++++++ .../bson-document-duplicate-keys-003.phpt | 42 ++++++++++ .../bson-document-duplicate-keys-004.phpt | 27 +++++++ 4 files changed, 175 insertions(+) create mode 100644 tests/bson/bson-document-duplicate-keys-001.phpt create mode 100644 tests/bson/bson-document-duplicate-keys-002.phpt create mode 100644 tests/bson/bson-document-duplicate-keys-003.phpt create mode 100644 tests/bson/bson-document-duplicate-keys-004.phpt diff --git a/tests/bson/bson-document-duplicate-keys-001.phpt b/tests/bson/bson-document-duplicate-keys-001.phpt new file mode 100644 index 000000000..46ffc3f3e --- /dev/null +++ b/tests/bson/bson-document-duplicate-keys-001.phpt @@ -0,0 +1,27 @@ +--TEST-- +MongoDB\BSON\Document: Encoding duplicate keys +--DESCRIPTION-- +BSON corpus spec prose test #2.1 (encoding) +https://github.com/mongodb/specifications/blob/master/source/bson-corpus/bson-corpus.md#21-test-encoding +--FILE-- + 1, 'foo' => 2]); + +echo "PHP collapses duplicate keys, keeping the last value\n"; +echo $document->toRelaxedExtendedJSON(), "\n"; +var_dump((string) $document === hex2bin('0e00000010666f6f000200000000')); + +?> +===DONE=== + +--EXPECT-- +PHP collapses duplicate keys, keeping the last value +{ "foo" : 2 } +bool(true) +===DONE=== diff --git a/tests/bson/bson-document-duplicate-keys-002.phpt b/tests/bson/bson-document-duplicate-keys-002.phpt new file mode 100644 index 000000000..7b642b9d7 --- /dev/null +++ b/tests/bson/bson-document-duplicate-keys-002.phpt @@ -0,0 +1,79 @@ +--TEST-- +MongoDB\BSON\Document: Decoding BSON with duplicate keys +--DESCRIPTION-- +BSON corpus spec prose test #2.2 (decoding) +https://github.com/mongodb/specifications/blob/master/source/bson-corpus/bson-corpus.md#22-test-decoding +--FILE-- + $value) { + var_dump($key, $value); +} + +echo "\nget() and offsetGet() return the first value\n"; +var_dump($document->get('foo')); +var_dump($document['foo']); +var_dump($document->has('foo')); + +echo "\ntoPHP() keeps the last value for object type maps\n"; +var_dump($document->toPHP()); +var_dump($document->toPHP(['root' => 'object'])); + +echo "\ntoPHP() keeps the last value for array type maps\n"; +var_dump($document->toPHP(['root' => 'array'])); + +echo "\ntoPHP() with the bson type map preserves duplicates\n"; +$bsonDocument = $document->toPHP(['root' => 'bson']); +var_dump($bsonDocument instanceof MongoDB\BSON\Document); +echo $bsonDocument->toRelaxedExtendedJSON(), "\n"; + +echo "\nExtended JSON preserves duplicates\n"; +echo $document->toRelaxedExtendedJSON(), "\n"; +echo $document->toCanonicalExtendedJSON(), "\n"; + +?> +===DONE=== + +--EXPECTF-- +Iteration returns both elements in order +string(3) "foo" +int(1) +string(3) "foo" +int(2) + +get() and offsetGet() return the first value +int(1) +int(1) +bool(true) + +toPHP() keeps the last value for object type maps +object(stdClass)#%d (1) { + ["foo"]=> + int(2) +} +object(stdClass)#%d (1) { + ["foo"]=> + int(2) +} + +toPHP() keeps the last value for array type maps +array(1) { + ["foo"]=> + int(2) +} + +toPHP() with the bson type map preserves duplicates +bool(true) +{ "foo" : 1, "foo" : 2 } + +Extended JSON preserves duplicates +{ "foo" : 1, "foo" : 2 } +{ "foo" : { "$numberInt" : "1" }, "foo" : { "$numberInt" : "2" } } +===DONE=== diff --git a/tests/bson/bson-document-duplicate-keys-003.phpt b/tests/bson/bson-document-duplicate-keys-003.phpt new file mode 100644 index 000000000..fea1e62e5 --- /dev/null +++ b/tests/bson/bson-document-duplicate-keys-003.phpt @@ -0,0 +1,42 @@ +--TEST-- +MongoDB\BSON\Document: Round-trip of BSON with duplicate keys +--DESCRIPTION-- +BSON corpus spec prose test #2.3 (round-trip) +https://github.com/mongodb/specifications/blob/master/source/bson-corpus/bson-corpus.md#23-test-round-trip +--FILE-- +toRelaxedExtendedJSON()); +echo $fromJson->toRelaxedExtendedJSON(), "\n"; +var_dump((string) $fromJson === $bson); + +echo "\nRound-trip through PHP keeps the last value\n"; +$roundTrip = MongoDB\BSON\Document::fromPHP($document->toPHP()); +echo $roundTrip->toRelaxedExtendedJSON(), "\n"; +var_dump((string) $roundTrip === $bson); + +?> +===DONE=== + +--EXPECT-- +Raw BSON is preserved +bool(true) + +Round-trip through Extended JSON preserves duplicates +{ "foo" : 1, "foo" : 2 } +bool(true) + +Round-trip through PHP keeps the last value +{ "foo" : 2 } +bool(false) +===DONE=== diff --git a/tests/bson/bson-document-duplicate-keys-004.phpt b/tests/bson/bson-document-duplicate-keys-004.phpt new file mode 100644 index 000000000..8dcf68298 --- /dev/null +++ b/tests/bson/bson-document-duplicate-keys-004.phpt @@ -0,0 +1,27 @@ +--TEST-- +MongoDB\BSON\Document: Parsing Extended JSON with duplicate keys +--DESCRIPTION-- +BSON corpus spec prose test #2.4 (parsing Extended JSON) +https://github.com/mongodb/specifications/blob/master/source/bson-corpus/bson-corpus.md#24-test-parsing-extended-json +--FILE-- +toRelaxedExtendedJSON(), "\n"; +var_dump((string) $document === $expected); + +?> +===DONE=== + +--EXPECT-- +Duplicate keys are preserved in order +{ "foo" : 1, "foo" : 2 } +bool(true) +===DONE===