Skip to content

Rule produces false positives very frequently #2

@RoystonS

Description

@RoystonS

Lots of valid commit messages are rejected incorrectly:

  • Reduce duplication in codebase - this is incorrectly flagged as past tense because the word 'Reduce' contains the letters 'ed'. I presume the code is attempting to detect words ending 'ed', but the regex is matching words that contain 'ed'.
  • Add missing directive to foobar - this is incorrectly flagged as a gerund because the word 'missing' (which isn't a verb) ends 'ing'. Adjectives like 'missing' or nouns like 'warning' occur quite frequently in commit messages, so checking anything other than the first word in the commit produces a lot of false positives.
  • Fix compiler warnings in foobar - this is incorrectly flagged as a gerund because the word 'warning' contains the letters 'ing'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions