|
| 1 | +package dashboard |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "encoding/json" |
| 6 | + "net/http" |
| 7 | + "net/http/httptest" |
| 8 | + "testing" |
| 9 | +) |
| 10 | + |
| 11 | +// mockDPoP implements ports.DPoP for testing. |
| 12 | +type mockDPoP struct { |
| 13 | + proof string |
| 14 | + err error |
| 15 | +} |
| 16 | + |
| 17 | +func (m *mockDPoP) GenerateProof(method, url, accessToken string) (string, error) { |
| 18 | + return m.proof, m.err |
| 19 | +} |
| 20 | + |
| 21 | +func (m *mockDPoP) Thumbprint() string { |
| 22 | + return "test-thumbprint" |
| 23 | +} |
| 24 | + |
| 25 | +func TestSetDPoPProof(t *testing.T) { |
| 26 | + tests := []struct { |
| 27 | + name string |
| 28 | + proof string |
| 29 | + proofErr error |
| 30 | + wantHeader string |
| 31 | + wantErr bool |
| 32 | + }{ |
| 33 | + { |
| 34 | + name: "sets DPoP header on success", |
| 35 | + proof: "test-proof-jwt", |
| 36 | + wantHeader: "test-proof-jwt", |
| 37 | + }, |
| 38 | + { |
| 39 | + name: "returns error on failure", |
| 40 | + proofErr: errTestDPoP, |
| 41 | + wantErr: true, |
| 42 | + }, |
| 43 | + } |
| 44 | + |
| 45 | + for _, tt := range tests { |
| 46 | + t.Run(tt.name, func(t *testing.T) { |
| 47 | + client := &AccountClient{ |
| 48 | + dpop: &mockDPoP{proof: tt.proof, err: tt.proofErr}, |
| 49 | + } |
| 50 | + |
| 51 | + req := httptest.NewRequest(http.MethodPost, "https://example.com/test", nil) |
| 52 | + err := client.setDPoPProof(req, http.MethodPost, "https://example.com/test", "token") |
| 53 | + |
| 54 | + if tt.wantErr { |
| 55 | + if err == nil { |
| 56 | + t.Fatal("expected error, got nil") |
| 57 | + } |
| 58 | + return |
| 59 | + } |
| 60 | + |
| 61 | + if err != nil { |
| 62 | + t.Fatalf("unexpected error: %v", err) |
| 63 | + } |
| 64 | + |
| 65 | + if got := req.Header.Get("DPoP"); got != tt.wantHeader { |
| 66 | + t.Errorf("DPoP header = %q, want %q", got, tt.wantHeader) |
| 67 | + } |
| 68 | + }) |
| 69 | + } |
| 70 | +} |
| 71 | + |
| 72 | +var errTestDPoP = &testError{msg: "dpop generation failed"} |
| 73 | + |
| 74 | +type testError struct{ msg string } |
| 75 | + |
| 76 | +func (e *testError) Error() string { return e.msg } |
| 77 | + |
| 78 | +func TestParseErrorResponse(t *testing.T) { |
| 79 | + tests := []struct { |
| 80 | + name string |
| 81 | + statusCode int |
| 82 | + body string |
| 83 | + wantMsg string |
| 84 | + }{ |
| 85 | + { |
| 86 | + name: "parses error with code and message", |
| 87 | + statusCode: 400, |
| 88 | + body: `{"error":{"code":"invalid_request","message":"bad input"}}`, |
| 89 | + wantMsg: "invalid_request: bad input", |
| 90 | + }, |
| 91 | + { |
| 92 | + name: "parses error with message only", |
| 93 | + statusCode: 500, |
| 94 | + body: `{"error":{"message":"internal error"}}`, |
| 95 | + wantMsg: "internal error", |
| 96 | + }, |
| 97 | + { |
| 98 | + name: "falls back to raw body", |
| 99 | + statusCode: 502, |
| 100 | + body: "Bad Gateway", |
| 101 | + wantMsg: "Bad Gateway", |
| 102 | + }, |
| 103 | + { |
| 104 | + name: "truncates long body", |
| 105 | + statusCode: 500, |
| 106 | + body: string(make([]byte, 300)), |
| 107 | + wantMsg: "", // truncated to 200 chars |
| 108 | + }, |
| 109 | + } |
| 110 | + |
| 111 | + for _, tt := range tests { |
| 112 | + t.Run(tt.name, func(t *testing.T) { |
| 113 | + err := parseErrorResponse(tt.statusCode, []byte(tt.body)) |
| 114 | + dashErr, ok := err.(*DashboardAPIError) |
| 115 | + if !ok { |
| 116 | + t.Fatalf("expected *DashboardAPIError, got %T", err) |
| 117 | + } |
| 118 | + if dashErr.StatusCode != tt.statusCode { |
| 119 | + t.Errorf("StatusCode = %d, want %d", dashErr.StatusCode, tt.statusCode) |
| 120 | + } |
| 121 | + if tt.wantMsg != "" && dashErr.ServerMsg != tt.wantMsg { |
| 122 | + t.Errorf("ServerMsg = %q, want %q", dashErr.ServerMsg, tt.wantMsg) |
| 123 | + } |
| 124 | + }) |
| 125 | + } |
| 126 | +} |
| 127 | + |
| 128 | +func TestUnwrapEnvelope(t *testing.T) { |
| 129 | + tests := []struct { |
| 130 | + name string |
| 131 | + body string |
| 132 | + wantKey string |
| 133 | + wantErr bool |
| 134 | + }{ |
| 135 | + { |
| 136 | + name: "unwraps data field", |
| 137 | + body: `{"request_id":"abc","success":true,"data":{"name":"test"}}`, |
| 138 | + wantKey: "name", |
| 139 | + }, |
| 140 | + { |
| 141 | + name: "returns body as-is when no data field", |
| 142 | + body: `{"name":"test"}`, |
| 143 | + wantKey: "name", |
| 144 | + }, |
| 145 | + { |
| 146 | + name: "returns error on invalid JSON", |
| 147 | + body: "not json", |
| 148 | + wantErr: true, |
| 149 | + }, |
| 150 | + } |
| 151 | + |
| 152 | + for _, tt := range tests { |
| 153 | + t.Run(tt.name, func(t *testing.T) { |
| 154 | + result, err := unwrapEnvelope([]byte(tt.body)) |
| 155 | + if tt.wantErr { |
| 156 | + if err == nil { |
| 157 | + t.Fatal("expected error, got nil") |
| 158 | + } |
| 159 | + return |
| 160 | + } |
| 161 | + if err != nil { |
| 162 | + t.Fatalf("unexpected error: %v", err) |
| 163 | + } |
| 164 | + |
| 165 | + var parsed map[string]any |
| 166 | + if jsonErr := json.Unmarshal(result, &parsed); jsonErr != nil { |
| 167 | + t.Fatalf("result is not valid JSON: %v", jsonErr) |
| 168 | + } |
| 169 | + if _, ok := parsed[tt.wantKey]; !ok { |
| 170 | + t.Errorf("result missing key %q: %s", tt.wantKey, string(result)) |
| 171 | + } |
| 172 | + }) |
| 173 | + } |
| 174 | +} |
| 175 | + |
| 176 | +func TestDashboardAPIError_Error(t *testing.T) { |
| 177 | + tests := []struct { |
| 178 | + name string |
| 179 | + err DashboardAPIError |
| 180 | + wantStr string |
| 181 | + }{ |
| 182 | + { |
| 183 | + name: "with message", |
| 184 | + err: DashboardAPIError{StatusCode: 400, ServerMsg: "bad request"}, |
| 185 | + wantStr: "dashboard API error (HTTP 400): bad request", |
| 186 | + }, |
| 187 | + { |
| 188 | + name: "without message", |
| 189 | + err: DashboardAPIError{StatusCode: 500}, |
| 190 | + wantStr: "dashboard API error (HTTP 500)", |
| 191 | + }, |
| 192 | + } |
| 193 | + |
| 194 | + for _, tt := range tests { |
| 195 | + t.Run(tt.name, func(t *testing.T) { |
| 196 | + if got := tt.err.Error(); got != tt.wantStr { |
| 197 | + t.Errorf("Error() = %q, want %q", got, tt.wantStr) |
| 198 | + } |
| 199 | + }) |
| 200 | + } |
| 201 | +} |
| 202 | + |
| 203 | +func TestDoPostAndGet_Integration(t *testing.T) { |
| 204 | + // Set up a test server that returns a valid envelope response |
| 205 | + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 206 | + // Verify DPoP header was set |
| 207 | + if dpop := r.Header.Get("DPoP"); dpop == "" { |
| 208 | + t.Error("DPoP header not set") |
| 209 | + } |
| 210 | + |
| 211 | + w.Header().Set("Content-Type", "application/json") |
| 212 | + resp := map[string]any{ |
| 213 | + "request_id": "test-123", |
| 214 | + "success": true, |
| 215 | + "data": map[string]string{"id": "app-1", "name": "Test App"}, |
| 216 | + } |
| 217 | + _ = json.NewEncoder(w).Encode(resp) |
| 218 | + })) |
| 219 | + defer server.Close() |
| 220 | + |
| 221 | + client := &AccountClient{ |
| 222 | + baseURL: server.URL, |
| 223 | + httpClient: server.Client(), |
| 224 | + dpop: &mockDPoP{proof: "test-proof"}, |
| 225 | + } |
| 226 | + |
| 227 | + t.Run("doPost decodes response", func(t *testing.T) { |
| 228 | + var result map[string]string |
| 229 | + err := client.doPost(context.Background(), "/test", nil, nil, "token", &result) |
| 230 | + if err != nil { |
| 231 | + t.Fatalf("unexpected error: %v", err) |
| 232 | + } |
| 233 | + if result["id"] != "app-1" { |
| 234 | + t.Errorf("result[id] = %q, want %q", result["id"], "app-1") |
| 235 | + } |
| 236 | + }) |
| 237 | + |
| 238 | + t.Run("doGet decodes response", func(t *testing.T) { |
| 239 | + var result map[string]string |
| 240 | + err := client.doGet(context.Background(), "/test", nil, "token", &result) |
| 241 | + if err != nil { |
| 242 | + t.Fatalf("unexpected error: %v", err) |
| 243 | + } |
| 244 | + if result["name"] != "Test App" { |
| 245 | + t.Errorf("result[name] = %q, want %q", result["name"], "Test App") |
| 246 | + } |
| 247 | + }) |
| 248 | +} |
0 commit comments