Update Symfony dependencies to 7.4+, refactor route loader to use attribute class

Author: yceruto

composer.json

@@ -14,12 +14,12 @@
     ],
     "require": {
         "php": ">=8.2",
-        "symfony/framework-bundle": "^7.0|^8.0",
-        "symfony/property-access": "^7.0|^8.0",
-        "symfony/serializer": "^7.0|^8.0",
-        "symfony/validator": "^7.0|^8.0",
+        "symfony/framework-bundle": "^7.4|^8.0",
+        "symfony/property-access": "^7.4|^8.0",
+        "symfony/serializer": "^7.4|^8.0",
+        "symfony/validator": "^7.4|^8.0",
         "zircote/swagger-php": "^4.7",
-        "symfony/expression-language": "^7.0|^8.0"
+        "symfony/expression-language": "^7.4|^8.0"
     },
     "require-dev": {
         "roave/security-advisories": "dev-latest",

config/services/routing.php

@@ -13,31 +13,31 @@
         ->set('routing.loader.attribute.post')
             ->class(OpenApiRouteControllerLoader::class)
             ->args(['%kernel.environment%'])
-            ->call('setRouteAnnotationClass', [Post::class])
+            ->call('setRouteAttributeClass', [Post::class])
             ->tag('routing.loader', ['priority' => -5])
 
         ->set('routing.loader.attribute.get')
             ->class(OpenApiRouteControllerLoader::class)
             ->args(['%kernel.environment%'])
-            ->call('setRouteAnnotationClass', [Get::class])
+            ->call('setRouteAttributeClass', [Get::class])
             ->tag('routing.loader', ['priority' => -5])
 
         ->set('routing.loader.attribute.put')
             ->class(OpenApiRouteControllerLoader::class)
             ->args(['%kernel.environment%'])
-            ->call('setRouteAnnotationClass', [Put::class])
+            ->call('setRouteAttributeClass', [Put::class])
             ->tag('routing.loader', ['priority' => -5])
 
         ->set('routing.loader.attribute.patch')
             ->class(OpenApiRouteControllerLoader::class)
             ->args(['%kernel.environment%'])
-            ->call('setRouteAnnotationClass', [Patch::class])
+            ->call('setRouteAttributeClass', [Patch::class])
             ->tag('routing.loader', ['priority' => -5])
 
         ->set('routing.loader.attribute.delete')
             ->class(OpenApiRouteControllerLoader::class)
             ->args(['%kernel.environment%'])
-            ->call('setRouteAnnotationClass', [Delete::class])
+            ->call('setRouteAttributeClass', [Delete::class])
             ->tag('routing.loader', ['priority' => -5])
     ;
 };

src/Routing/Attribute/ApiRouteTrait.php

@@ -105,5 +105,16 @@ public function __call(string $name, array $arguments): mixed
         return $this->route->{$name}(...$arguments);
     }
 
+    public function __get(string $name): mixed
+    {
+        if (property_exists($this->route, $name)) {
+            return $this->route->{$name};
+        }
+
+        parent::__get($name);
+
+        return null;
+    }
+
     abstract public function getMethod(): string;
 }

src/Routing/Loader/OpenApiRouteControllerLoader.php

@@ -17,17 +17,26 @@
 
 class OpenApiRouteControllerLoader extends AttributeRouteControllerLoader
 {
+    private string $routeAttributeClass;
+
     public function supports(mixed $resource, ?string $type = null): bool
     {
         return parent::supports($resource, $type) && $this->isOpenApiController($resource);
     }
 
+    public function setRouteAttributeClass(string $class): void
+    {
+        $this->routeAttributeClass = $class;
+
+        parent::setRouteAttributeClass($class);
+    }
+
     private function isOpenApiController(mixed $resource): bool
     {
         $reflection = new \ReflectionClass($resource);
 
         foreach ($reflection->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
-            if ($reflectionMethod->getAttributes($this->routeAnnotationClass, \ReflectionAttribute::IS_INSTANCEOF)) {
+            if ($reflectionMethod->getAttributes($this->routeAttributeClass, \ReflectionAttribute::IS_INSTANCEOF)) {
                 return true;
             }
         }

tests/Functional/App/PostResourceAction/Output/validation_error2.json

@@ -1 +1 @@
-{"type":"https:\/\/symfony.com\/errors\/validation","title":"Validation Failed","status":422,"detail":"name: This value is too short. It should have 3 characters or more.\nstatus: The value you selected is not a valid choice.","violations":[{"propertyPath":"name","title":"This value is too short. It should have 3 characters or more.","template":"This value is too short. It should have {{ limit }} character or more.|This value is too short. It should have {{ limit }} characters or more.","parameters":{"{{ value }}":"\"fo\"","{{ limit }}":"3","{{ value_length }}":"2"},"type":"urn:uuid:9ff3fdc4-b214-49db-8718-39c315e33d45"},{"propertyPath":"status","title":"The value you selected is not a valid choice.","template":"The value you selected is not a valid choice.","parameters":{"{{ value }}":"\"dra\"","{{ choices }}":"\"draft\", \"published\""},"type":"urn:uuid:8e179f1b-97aa-4560-a02f-2a8b42e49df7"}]}
+{"type":"https:\/\/symfony.com\/errors\/validation","title":"Validation Failed","status":422,"detail":"name: This value is too short. It should have 3 characters or more.\nstatus: The value you selected is not a valid choice.","violations":[{"propertyPath":"name","title":"This value is too short. It should have 3 characters or more.","template":"This value is too short. It should have {{ limit }} character or more.|This value is too short. It should have {{ limit }} characters or more.","parameters":{"{{ value }}":"\"fo\"","{{ limit }}":"3","{{ min }}":"3","{{ value_length }}":"2"},"type":"urn:uuid:9ff3fdc4-b214-49db-8718-39c315e33d45"},{"propertyPath":"status","title":"The value you selected is not a valid choice.","template":"The value you selected is not a valid choice.","parameters":{"{{ value }}":"\"dra\"","{{ choices }}":"\"draft\", \"published\""},"type":"urn:uuid:8e179f1b-97aa-4560-a02f-2a8b42e49df7"}]}

tests/Functional/App/config.yaml

@@ -1,5 +1,4 @@
 framework:
-    annotations: false
     http_method_override: false
     handle_all_throwables: true
     secret: test