From ef32797cdc5de5f01443b3f163e51466b533e59d Mon Sep 17 00:00:00 2001 From: xli-oai Date: Wed, 6 May 2026 22:34:33 -0700 Subject: [PATCH] Stop spelling skills extra roots in TUI requests --- codex-rs/app-server-protocol/src/protocol/common.rs | 5 ++++- codex-rs/app-server-protocol/src/protocol/v2/plugin.rs | 2 +- codex-rs/tui/src/app/background_requests.rs | 2 +- codex-rs/tui/src/app/thread_routing.rs | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/codex-rs/app-server-protocol/src/protocol/common.rs b/codex-rs/app-server-protocol/src/protocol/common.rs index 506c0d512de4..d687a79ec945 100644 --- a/codex-rs/app-server-protocol/src/protocol/common.rs +++ b/codex-rs/app-server-protocol/src/protocol/common.rs @@ -1674,7 +1674,10 @@ mod tests { let plugin_list = ClientRequest::PluginList { request_id: request_id(), - params: v2::PluginListParams { cwds: None }, + params: v2::PluginListParams { + cwds: None, + marketplace_kinds: None, + }, }; assert_eq!( plugin_list.serialization_scope(), diff --git a/codex-rs/app-server-protocol/src/protocol/v2/plugin.rs b/codex-rs/app-server-protocol/src/protocol/v2/plugin.rs index b2d5d85c299d..bdb15288146b 100644 --- a/codex-rs/app-server-protocol/src/protocol/v2/plugin.rs +++ b/codex-rs/app-server-protocol/src/protocol/v2/plugin.rs @@ -15,7 +15,7 @@ use serde::Serialize; use std::path::PathBuf; use ts_rs::TS; -#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] +#[derive(Serialize, Deserialize, Debug, Clone, Default, PartialEq, JsonSchema, TS)] #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] pub struct SkillsListParams { diff --git a/codex-rs/tui/src/app/background_requests.rs b/codex-rs/tui/src/app/background_requests.rs index 82cbd9f3017f..fcfbc3ac0fee 100644 --- a/codex-rs/tui/src/app/background_requests.rs +++ b/codex-rs/tui/src/app/background_requests.rs @@ -648,7 +648,7 @@ pub(super) async fn fetch_skills_list( params: SkillsListParams { cwds: vec![cwd], force_reload: true, - per_cwd_extra_user_roots: None, + ..Default::default() }, }) .await diff --git a/codex-rs/tui/src/app/thread_routing.rs b/codex-rs/tui/src/app/thread_routing.rs index 1a7986ad31de..47b2571bc7d2 100644 --- a/codex-rs/tui/src/app/thread_routing.rs +++ b/codex-rs/tui/src/app/thread_routing.rs @@ -621,7 +621,7 @@ impl App { .skills_list(codex_app_server_protocol::SkillsListParams { cwds: cwds.clone(), force_reload: *force_reload, - per_cwd_extra_user_roots: None, + ..Default::default() }) .await, "failed to refresh skills",