Add H&E data loader#40
Open
heylf wants to merge 3 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rcannood
requested changes
May 19, 2026
Member
rcannood
left a comment
rcannood
left a comment
There was a problem hiding this comment.
Wait no, there is something wrong with the config. In the CI:
Reading file 'src/datasets/loaders/hae/config.vsh.yaml' failed
Can you run viash test src/datasets/loaders/hae/config.vsh.yaml ? This should tell you what's wrong with the dataset loader
Contributor
Author
|
Yeah. It is a bit for discussion now how we deal with H&E. I think it would be great now to have a metric that utlized this data type. I think I made a mistake to implement a separate workflow for the data type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!