From 8c262391359a2c626cc42562bf2d0fa038773546 Mon Sep 17 00:00:00 2001 From: Brock McElroy <28877984+brxck@users.noreply.github.com> Date: Thu, 8 Oct 2026 16:20:12 +0000 Subject: [PATCH] fix(app): dispose server roots when the app unmounts --- packages/app/src/runtime/server/runtime.tsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/app/src/runtime/server/runtime.tsx b/packages/app/src/runtime/server/runtime.tsx index 639c845b0db7..d7b1c6390317 100644 --- a/packages/app/src/runtime/server/runtime.tsx +++ b/packages/app/src/runtime/server/runtime.tsx @@ -1,5 +1,5 @@ import { createSimpleContext } from "@opencode-ai/ui/context" -import { Accessor, createEffect, createMemo, createResource, createRoot, getOwner } from "solid-js" +import { Accessor, createEffect, createMemo, createResource, createRoot, getOwner, onCleanup } from "solid-js" import { createStore } from "solid-js/store" import { createServerProjects, RECENTLY_CLOSED_DISPLAY_LIMIT, ServerConnection, useServers } from "./registry" import { pathKey } from "@/workspaces/path-key" @@ -73,6 +73,14 @@ export const { use: useGlobal, provider: GlobalProvider } = createSimpleContext( } }) + // These roots outlive the provider unless disposed here. A leaked root keeps its event stream + // open and reconnecting, so repeated remounts exhaust the browser's per-origin connections. + onCleanup(() => { + for (const dispose of serverCtxDisposers.values()) dispose() + serverCtxDisposers.clear() + serverCtxs.clear() + }) + return { servers: { list: () => server.list,