Some observations as a drive-by contributor, it would be lovely if:
- there was a pull request template
- the
--diff settings in the CI linters told the whole story
- maybe go to the all-in-one
ruff (vs black + isort) which is a good deal simpler to reason about
- the
mypy settings caught more things: files = src/packageurl/__init__.py isn't really finding the things a downstream would hit with the equivalent of mypy -p packageurl when used as a dependency
Originally posted by @bollwyvl in #213 (comment)
Some observations as a drive-by contributor, it would be lovely if:
--diffsettings in the CI linters told the whole storyruff(vsblack + isort) which is a good deal simpler to reason aboutmypysettings caught more things:files = src/packageurl/__init__.pyisn't really finding the things a downstream would hit with the equivalent ofmypy -p packageurlwhen used as a dependencyOriginally posted by @bollwyvl in #213 (comment)