Improve compare#22
Merged
johannes-moegerle merged 5 commits intoMay 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the local comparison tooling (states + matrix elements) and adjusts dependency metadata related to comparison/mypy extras.
Changes:
- Updates
tools/compare/*scripts for MQDT-oriented comparisons (paths, index columns, tolerances, verbosity controls). - Removes the
comparisonextra dependencies from the lockedrydstatemetadata and updates provided extras accordingly. - Removes a mypy ignore in Wigner table generation and pins the mypy pre-commit
rydstatedependency.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Removes comparison extra deps and drops comparison from provides-extras; adds typing-extensions for mypy. |
tools/compare/compare_states.py |
Adjusts MQDT indexing/rounding, tolerances, and verbosity behavior for state-table comparisons. |
tools/compare/compare_matrix_elements.py |
Updates MQDT index columns and default comparison ranges for matrix elements. |
src/generate_database_sqdt/generate_misc.py |
Drops a type: ignore on a calc_wigner_3j_with_symmetries call. |
.pre-commit-config.yaml |
Pins mypy hook’s rydstate dependency version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johannes-moegerle
force-pushed
the
improve-compare
branch
from
0466c87 to
551c99e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.