Repository navigation
Commit 73d71aa
Fix GH-25434: C14NFile() skips namespace relinking on success
For modern DOM, dom_canonicalization() takes the xmlns:* attributes off their
elements before canonicalizing and puts them back at clean_links. On success,
C14NFile() returned early with RETURN_LONG(), so the declarations stayed
detached and the links table leaked. It now sets the return value and falls
through to the cleanup like C14N() does, returning false when
xmlOutputBufferClose() fails.
Close GH-254351 parent f983e1a commit 73d71aa
3 files changed
Lines changed: 29 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2331 | 2331 | | |
2332 | 2332 | | |
2333 | 2333 | | |
2334 | | - | |
| 2334 | + | |
| 2335 | + | |
| 2336 | + | |
| 2337 | + | |
| 2338 | + | |
2335 | 2339 | | |
2336 | 2340 | | |
2337 | 2341 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
0 commit comments