Repository navigation
Commit 9d14b9b
committed
Speed up zend_hash_iterator_add() when iterators are nested
zend_hash_iterator_add() scanned EG(ht_iterators) from slot 0 on every
call, so each nested foreach by reference, foreach over object
properties, ArrayIterator or array_walk() paid one probe per iterator
already alive.
EG(ht_iterators_free_hint) tracks that all slots below it are in use:
zend_hash_iterator_add() starts looking from there and
zend_hash_iterator_del() lowers it. The returned slot is still the
lowest free one, so slot indexes and EG(ht_iterators_used) are the same
as before.1 parent 6c0388f commit 9d14b9b
3 files changed
Lines changed: 13 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| 185 | + | |
185 | 186 | | |
186 | 187 | | |
187 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
282 | 282 | | |
283 | 283 | | |
284 | 284 | | |
| 285 | + | |
285 | 286 | | |
286 | 287 | | |
287 | 288 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
689 | 689 | | |
690 | 690 | | |
691 | 691 | | |
692 | | - | |
693 | | - | |
694 | | - | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
695 | 695 | | |
696 | 696 | | |
697 | 697 | | |
698 | 698 | | |
699 | | - | |
| 699 | + | |
| 700 | + | |
700 | 701 | | |
701 | 702 | | |
702 | 703 | | |
703 | | - | |
704 | 704 | | |
| 705 | + | |
705 | 706 | | |
706 | 707 | | |
707 | 708 | | |
708 | 709 | | |
709 | 710 | | |
710 | | - | |
| 711 | + | |
711 | 712 | | |
712 | 713 | | |
713 | 714 | | |
| |||
723 | 724 | | |
724 | 725 | | |
725 | 726 | | |
| 727 | + | |
726 | 728 | | |
727 | 729 | | |
728 | 730 | | |
| |||
818 | 820 | | |
819 | 821 | | |
820 | 822 | | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
821 | 826 | | |
822 | 827 | | |
823 | 828 | | |
| |||
0 commit comments