From 998213fc478702949f9627359f734b3cc497df6b Mon Sep 17 00:00:00 2001 From: Jorg Sowa Date: Mon, 16 Nov 2026 10:27:45 +0100 Subject: [PATCH 1/2] Fix memory leak in get_meta_tags() on tag opened while expecting attribute value --- NEWS | 2 ++ ext/standard/file.c | 3 +++ .../strings/get_meta_tags_open_tag_leak.phpt | 25 +++++++++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 ext/standard/tests/strings/get_meta_tags_open_tag_leak.phpt diff --git a/NEWS b/NEWS index b655a47a6f15..bb5f6b75b07b 100644 --- a/NEWS +++ b/NEWS @@ -117,6 +117,8 @@ PHP NEWS (Kévin Dunglas) . Fixed bug GH-24743 (var_export() ignores exceptions from lazy object initialization). (lazerg) + . Fixed memory leak in get_meta_tags() when a tag opens while an attribute + value is expected. (Jorg Sowa) - Streams: . Fixed bug GH-22063 (Stream filter chain UAF on self-removal during diff --git a/ext/standard/file.c b/ext/standard/file.c index 412af159f19e..e521c3c0911c 100644 --- a/ext/standard/file.c +++ b/ext/standard/file.c @@ -334,6 +334,9 @@ PHP_FUNCTION(get_meta_tags) looking_for_val = 0; } else if (tok == TOK_OPENTAG) { if (looking_for_val) { + if (name) efree(name); + if (value) efree(value); + name = value = NULL; looking_for_val = 0; have_name = saw_name = 0; have_content = saw_content = 0; diff --git a/ext/standard/tests/strings/get_meta_tags_open_tag_leak.phpt b/ext/standard/tests/strings/get_meta_tags_open_tag_leak.phpt new file mode 100644 index 000000000000..01f8e4253670 --- /dev/null +++ b/ext/standard/tests/strings/get_meta_tags_open_tag_leak.phpt @@ -0,0 +1,25 @@ +--TEST-- +get_meta_tags() does not leak when a tag opens while an attribute value is expected +--FILE-- + + + +HTML); + +var_dump(get_meta_tags($filename)); + +?> +--CLEAN-- + +--EXPECT-- +array(1) { + ["baz"]=> + string(3) "qux" +} From 2a6e83b5ac98c1ad8e9d28af15a0e3b0743a0a66 Mon Sep 17 00:00:00 2001 From: Jorg Sowa Date: Mon, 16 Nov 2026 22:10:34 +0100 Subject: [PATCH 2/2] Free name/value on close tag based on pointers, not flags --- ext/standard/file.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/ext/standard/file.c b/ext/standard/file.c index e521c3c0911c..eab4aa7f4b74 100644 --- a/ext/standard/file.c +++ b/ext/standard/file.c @@ -334,9 +334,6 @@ PHP_FUNCTION(get_meta_tags) looking_for_val = 0; } else if (tok == TOK_OPENTAG) { if (looking_for_val) { - if (name) efree(name); - if (value) efree(value); - name = value = NULL; looking_for_val = 0; have_name = saw_name = 0; have_content = saw_content = 0; @@ -351,13 +348,10 @@ PHP_FUNCTION(get_meta_tags) } else { add_assoc_string(return_value, name, ""); } - - efree(name); - if (value) efree(value); - } else if (have_content) { - efree(value); } + if (name) efree(name); + if (value) efree(value); name = value = NULL; /* Reset all of our flags */