From db0650c3e0dbafdf993546ae7c404a699d35021f Mon Sep 17 00:00:00 2001 From: Alexander Fisher Date: Thu, 4 Jun 2026 11:54:32 +0100 Subject: [PATCH] Allow setting `retain_repo_versions` to `null` Setting is already `NULLABLE` in `pulp-glue/src/pulp_glue/common/context.py` line 1586 ``` NULLABLES = {"description", "remote", "retain_repo_versions"} ``` but cli didn't allow an empty string to be used. --- CHANGES/+retain_repo_versions.bugfix | 1 + src/pulp_cli/generic.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 CHANGES/+retain_repo_versions.bugfix diff --git a/CHANGES/+retain_repo_versions.bugfix b/CHANGES/+retain_repo_versions.bugfix new file mode 100644 index 000000000..fa54fdb8a --- /dev/null +++ b/CHANGES/+retain_repo_versions.bugfix @@ -0,0 +1 @@ +Fixed empty string not being accepted as the value of `--retain-repo-versions`. diff --git a/src/pulp_cli/generic.py b/src/pulp_cli/generic.py index 0374af0c0..402e7155d 100644 --- a/src/pulp_cli/generic.py +++ b/src/pulp_cli/generic.py @@ -1368,7 +1368,7 @@ def _type_callback(ctx: click.Context, param: click.Parameter, value: str | None "--retain-repo-versions", needs_plugins=[PluginRequirement("core", specifier=">=3.13.0")], help=_("Number of repository versions to keep."), - type=int, + type=int_or_empty, ) pulp_labels_option = pulp_option(