Repository navigation
test_queue times out #115258
Description
Bug report
Bug description:
See https://github.com/python/cpython/actions/runs/7856342409/job/21439020143?pr=115257 for more details.
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Linked PRs
Reacted by pan324
Activity
colesbury commentedon Feb 11, 2024
I'll look into this on Monday. Here's a PR that temporarily skips this test on the free-threaded WIndows build, if we prefer that over reverting the PR: #115269
colesbury commentedon Feb 11, 2024
It looks like the test also sometimes times out on the default Windows build. In this job it timed out after 10 minutes, was re-run, and then passed: https://github.com/python/cpython/actions/runs/7859086848/job/21444802020?pr=115269
gvanrossum commentedon Feb 11, 2024
Oh, then just skip these tests on Windows.
[-]``test_queue`` timed out on Windows free-threading build[/-][+]``test_queue`` timed out on Windows ~~free-threading~~ build[/+][-]``test_queue`` timed out on Windows ~~free-threading~~ build[/-][+]``test_queue`` timed out on Windows build[/+][-]``test_queue`` timed out on Windows build[/-][+]``test_queue`` times out on Windows build[/+]gh-115258: Temporarily disable test on Windows (#115269)
gvanrossum commentedon Feb 11, 2024
I'll now commandeer this issue to track fixes to the offending tests. Hopefully @EpicWink has some ideas.
itamaro commentedon Feb 12, 2024
going to remove the free-threading label since the current theory is that this isn't free-threading specific.
brandtbucher commentedon Feb 12, 2024
We're seeing timeouts for
test_queueon some AArch64 JIT builds too: https://github.com/python/cpython/actions/runs/7870838905?pr=115248gvanrossum commentedon Feb 12, 2024
Okay, just disable those two tests for all platforms. (I'm not in a position to do it myself right now.)
[-]``test_queue`` times out on Windows build[/-][+]``test_queue`` times out[/+]pythongh-115258: Temporarily skip test on all platforms
Eclips4 commentedon Feb 12, 2024
Done in #115361
gh-115258: Temporarily skip some `queue` tests on all platforms (#115361
pythongh-115258: Temporarily disable test on Windows (python#115269)
pythongh-115258: Temporarily skip some `queue` tests on all platforms (…
WIP: fix threading queue shutdown all-methods-many-threads test (pyth…
WIP: fix threading queue shutdown all-methods-many-threads test (pyth…
vstinner commentedon Mar 14, 2024
What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.
gvanrossum commentedon Mar 14, 2024
Funny you should ask. There is a fix by the original authors (gh-115940), it just requires review and some validation. I don't want to rush things. Could you maybe review that PR?
gh-115258: Fix hanging tests for threading queue shutdown (#115940)
gvanrossum commentedon Mar 18, 2024
The updated tests have been pushed.
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…