Generate initialHidden as an optional prop for VirtualView (#58864)

Summary:

`VirtualViewNativeComponent` declared `initialHidden?: boolean`, which codegen generated as a plain `bool` defaulting to `false`. On Android, props equal to their C++ default are not sent when a view is created, so an explicit `initialHidden={false}` never reached `ReactVirtualViewManager.setInitialHidden`. The view's `mode` stayed `null`, so it emitted a synchronous `Visible` mode change on its first update, emitted a normally suppressed `Prerender` change, and skipped the clipping update when it first left `Visible`.

Declare the prop as `WithDefault<boolean, null>` and opt the spec into `generateOptionalProperties`, so `initialHidden` is a `std::optional<bool>` that is unset by default and an explicit `false` is sent. A plain `?: boolean` is not enough, because the Flow parser assigns it a `false` default. The `codegenNativeComponent` Flow options type gains the codegen options already declared in its TypeScript types, and iOS reads the prop with `value_or(false)`.

This changes generated APIs of VirtualView: `VirtualViewProps::initialHidden` becomes `std::optional<bool>`, and `VirtualViewManagerInterface.setInitialHidden` takes a nullable `Boolean`. The public JS API change is additive: `NativeComponentOptions` gains the optional `generateOptionalProperties` and `generateOptionalObjectProperties` fields, so the API snapshot reports `codegenNativeComponent` as changed without breaking existing callers.

Changelog: [General][Fixed] - Fix `VirtualView` initial mode when `initialHidden` is not sent on creation

Reviewed By: javache

Differential Revision: D123029234

Author: bartlomiejbloniarz

packages/react-native/Libraries/Utilities/codegenNativeComponent.js

@@ -21,6 +21,8 @@ type NativeComponentOptions = Readonly<{
   paperComponentName?: string,
   paperComponentNameDeprecated?: string,
   excludedPlatforms?: ReadonlyArray<'iOS' | 'android'>,
+  generateOptionalProperties?: boolean,
+  generateOptionalObjectProperties?: boolean,
 }>;
 
 // Note that this alias is not re-exported from the `react-native` root,

packages/react-native/React/Fabric/Mounting/ComponentViews/VirtualView/RCTVirtualViewComponentView.mm

@@ -63,7 +63,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   const auto &newViewProps = static_cast<const VirtualViewProps &>(*props);
 
   if (!_mode.has_value()) {
-    _mode = newViewProps.initialHidden ? RCTVirtualViewModeHidden : RCTVirtualViewModeVisible;
+    _mode = newViewProps.initialHidden.value_or(false) ? RCTVirtualViewModeHidden : RCTVirtualViewModeVisible;
   }
 
   switch (newViewProps.renderState) {

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -5152,7 +5152,7 @@ public class com/facebook/react/viewmanagers/VirtualViewManagerDelegate : com/fa
 }
 
 public abstract interface class com/facebook/react/viewmanagers/VirtualViewManagerInterface : com/facebook/react/uimanager/ViewManagerWithGeneratedInterface {
-	public abstract fun setInitialHidden (Landroid/view/View;Z)V
+	public abstract fun setInitialHidden (Landroid/view/View;Ljava/lang/Boolean;)V
 	public abstract fun setRemoveClippedSubviews (Landroid/view/View;Z)V
 	public abstract fun setRenderState (Landroid/view/View;I)V
 }
@@ -6580,8 +6580,8 @@ public final class com/facebook/react/views/virtual/view/ReactVirtualViewManager
 	public synthetic fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Landroid/view/View;
 	public fun getName ()Ljava/lang/String;
 	public synthetic fun prepareToRecycleView (Lcom/facebook/react/uimanager/ThemedReactContext;Landroid/view/View;)Landroid/view/View;
-	public synthetic fun setInitialHidden (Landroid/view/View;Z)V
-	public fun setInitialHidden (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Z)V
+	public synthetic fun setInitialHidden (Landroid/view/View;Ljava/lang/Boolean;)V
+	public fun setInitialHidden (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Ljava/lang/Boolean;)V
 	public synthetic fun setNativeId (Landroid/view/View;Ljava/lang/String;)V
 	public fun setNativeId (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Ljava/lang/String;)V
 	public synthetic fun setRemoveClippedSubviews (Landroid/view/View;Z)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/virtual/view/ReactVirtualViewManager.kt

@@ -37,9 +37,9 @@ public class ReactVirtualViewManager :
       ReactVirtualView(reactContext)
 
   @ReactProp(name = "initialHidden")
-  override fun setInitialHidden(view: ReactVirtualView, value: Boolean) {
+  override fun setInitialHidden(view: ReactVirtualView, value: Boolean?) {
     if (view.mode == null) {
-      view.mode = if (value) VirtualViewMode.Hidden else VirtualViewMode.Visible
+      view.mode = if (value == true) VirtualViewMode.Hidden else VirtualViewMode.Visible
     }
   }
 

packages/react-native/ReactNativeApi.d.ts

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<6d379de092b8bad36a420658bbc25a6d>>
+ * @generated SignedSource<<c7bfb58714c5cd50a054ec7a0090b3f8>>
  *
  * This file was generated by scripts/js-api/build-types/index.js.
  */
@@ -3072,6 +3072,8 @@ declare type NativeCommandsOptions<T = string> = {
 }
 declare type NativeComponentOptions = {
   readonly excludedPlatforms?: ReadonlyArray<"android" | "iOS">
+  readonly generateOptionalObjectProperties?: boolean
+  readonly generateOptionalProperties?: boolean
   readonly interfaceOnly?: boolean
   readonly paperComponentName?: string
   readonly paperComponentNameDeprecated?: string
@@ -6055,7 +6057,7 @@ export {
   VirtualizedSectionListProps, // 8373f27c
   WrapperComponentProvider, // 9b4247f6
   codegenNativeCommands, // 322f3f4e
-  codegenNativeComponent, // e8334853
+  codegenNativeComponent, // 3da62daa
   findNodeHandle, // 93f80214
   processColor, // 6e877698
   registerCallableModule, // 839c8cfe

packages/react-native/src/private/components/virtualview/VirtualViewNativeComponent.js

@@ -13,6 +13,7 @@ import type {
   DirectEventHandler,
   Double,
   Int32,
+  WithDefault,
 } from '../../../../Libraries/Types/CodegenTypes';
 import type {HostComponent} from '../../types/HostComponent';
 
@@ -65,7 +66,7 @@ type VirtualViewNativeProps = Readonly<{
   /**
    * Whether the initial mode should be `Hidden`.
    */
-  initialHidden?: boolean,
+  initialHidden?: WithDefault<boolean, null>,
 
   /**
    * This was needed to get VirtualViewManagerDelegate to set this property.
@@ -93,4 +94,5 @@ type VirtualViewNativeProps = Readonly<{
 
 export default codegenNativeComponent<VirtualViewNativeProps>('VirtualView', {
   interfaceOnly: true,
+  generateOptionalProperties: true,
 }) as HostComponent<VirtualViewNativeProps>;

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -2575,9 +2575,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
 class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
   public VirtualViewProps() = default;
   public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
-  public bool initialHidden;
   public bool removeClippedSubviews;
   public int renderState;
+  public std::optional<bool> initialHidden;
   public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
   public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
 }

scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api

@@ -4415,9 +4415,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
 class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
   public VirtualViewProps() = default;
   public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
-  public bool initialHidden;
   public bool removeClippedSubviews;
   public int renderState;
+  public std::optional<bool> initialHidden;
   public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
   public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
 }

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

@@ -2568,9 +2568,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
 class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
   public VirtualViewProps() = default;
   public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
-  public bool initialHidden;
   public bool removeClippedSubviews;
   public int renderState;
+  public std::optional<bool> initialHidden;
   public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
   public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
 }

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

@@ -2568,9 +2568,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
 class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
   public VirtualViewProps() = default;
   public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
-  public bool initialHidden;
   public bool removeClippedSubviews;
   public int renderState;
+  public std::optional<bool> initialHidden;
   public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
   public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
 }