Make the HelloWorld dynamic-frameworks CI lane use dynamic frameworks

#54482 switched the test_ios_helloworld matrix to use_frameworks: [false, true] but left the test-ios-helloworld action comparing the input to "DynamicFrameworks", so the true lane builds with static libraries and the Debug exclude (StaticLibraries) matches nothing. Compare against "true" like test-ios-rntester does and exclude use_frameworks: false.

Author: xThreeh

.github/actions/test-ios-helloworld/action.yml

@@ -2,8 +2,8 @@ name: test-ios-helloworld
 description: Test iOS Hello World
 inputs:
   use-frameworks:
-    description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
-    default: StaticLibraries
+    description: Whether to build with dynamic frameworks.
+    default: false
   ruby-version:
     description: The version of ruby that must be used
     default: 2.6.10
@@ -51,7 +51,7 @@ runs:
         cd private/helloworld
         args=()
 
-        if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
+        if [[ "${{ inputs.use-frameworks }}" == "true" ]]; then
           args+=(--frameworks dynamic)
         fi
 

.github/workflows/test-all.yml

@@ -534,7 +534,7 @@ jobs:
         exclude:
           # This config is tested with Ruby 3.2.0. Let's not double test it.
           - flavor: Debug
-            use_frameworks: StaticLibraries
+            use_frameworks: false
     env:
       PROJECT_NAME: iOSTemplateProject
       YARN_ENABLE_IMMUTABLE_INSTALLS: false