Repository navigation
Commit 9b1940d
Decouple Hermes factory header from C++ paths
Summary:
`RCTHermesInstanceFactory.h` is part of React's umbrella header, but it imported a lower-level C++ header that was unavailable while a SwiftPM Release build compiled the `React` module. Forward-declare the opaque `JSRuntimeFactoryRef` handle instead of relying on transitive C++ header search paths.
This preserves the C ABI and mirrors the existing self-contained declaration used by `RCTJSRuntimeConfiguratorProtocol.h`. The first observed failure was at `024b474ce92ba66744af602ee67691cd11498485`; the immediately preceding `main` SPM Release run passed, but that commit only changed `RCTInstance.mm`, so source-level attribution remains uncertain. The risk is limited to keeping two equivalent opaque aliases in sync; both remain `void *`.
Validation covered the internal Apple runtime target, all React Native C++ API snapshot configurations, formatter, and lint. A full SwiftPM/Xcode rerun was not available on the Linux build host.
Changelog:
[iOS][Fixed] - Fix SwiftPM Release builds failing to compile the React umbrella module
Differential Revision: D1231429621 parent 024b474 commit 9b1940d
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
| 10 | + | |
12 | 11 | | |
| 12 | + | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
0 commit comments