Disable folly coroutines for library pods in install_modules_dependencies

Libraries that set their own folly compiler flags (e.g. -DFOLLY_NO_CONFIG without
-DFOLLY_CFG_NO_COROUTINES=1) enable folly coroutines under C++20. Since #58711,
RCTTurboModule.h transitively includes folly/dynamic.h, so these libraries fail to
build with 'folly/coro/Coroutine.h' file not found, because ReactNativeDependencies
does not ship the folly/coro headers.

Always append -DFOLLY_CFG_NO_COROUTINES=1 to the compiler flags set by
install_modules_dependencies.

Author: cipolleschi

packages/react-native/scripts/cocoapods/__tests__/new_architecture-test.rb

@@ -130,7 +130,7 @@ def test_installModulesDependencies_whenNewArchEnabledAndNewArchAndNoSearchPaths
         NewArchitectureHelper.install_modules_dependencies(spec, true, '2024.10.14.00')
 
         # Assert
-        assert_equal("-DRCT_NEW_ARCH_ENABLED=1", spec.compiler_flags)
+        assert_equal("-DRCT_NEW_ARCH_ENABLED=1 -DFOLLY_CFG_NO_COROUTINES=1", spec.compiler_flags)
         assert_equal(
             [
                 "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
@@ -206,6 +206,7 @@ def test_installModulesDependencies_whenNewArchDisabledAndSearchPathsAndCompiler
 
         # Assert
         assert_equal("#{NewArchitectureHelper.folly_compiler_flags}", Helpers::Constants.folly_config[:compiler_flags])
+        assert_equal("-DFOLLY_CFG_NO_COROUTINES=1", spec.compiler_flags)
         assert_equal([*other_flags_arr, '"$(PODS_ROOT)/Headers/Private/Yoga"', '$(PODS_ROOT)/glog', '$(PODS_ROOT)/boost', '$(PODS_ROOT)/DoubleConversion', '$(PODS_ROOT)/fast_float/include', '$(PODS_ROOT)/fmt/include', '$(PODS_ROOT)/SocketRocket', '$(PODS_ROOT)/RCT-Folly'], spec.pod_target_xcconfig["HEADER_SEARCH_PATHS"])
         assert_equal("c++20", spec.pod_target_xcconfig["CLANG_CXX_LANGUAGE_STANDARD"])
         assert_equal(

packages/react-native/scripts/cocoapods/new_architecture.rb

@@ -107,7 +107,10 @@ def self.install_modules_dependencies(spec, new_arch_enabled, folly_version = He
                 }
         end
         header_search_paths_string = header_search_paths.join(" ")
-        spec.compiler_flags = compiler_flags.empty? ? self.computeFlags(new_arch_enabled).strip! : "#{compiler_flags} #{self.computeFlags(new_arch_enabled)}"
+        # Libraries may pass their own folly flags, so always disable folly coroutines:
+        # ReactNativeDependencies does not ship the folly/coro headers.
+        module_compiler_flags = "#{self.computeFlags(new_arch_enabled).strip} -DFOLLY_CFG_NO_COROUTINES=1".strip
+        spec.compiler_flags = compiler_flags.empty? ? module_compiler_flags : "#{compiler_flags} #{module_compiler_flags}"
         current_config["HEADER_SEARCH_PATHS"] = current_headers.empty? ?
             header_search_paths_string :
             "#{current_headers} #{header_search_paths_string}"