From 6e5b88c1d03e5f7e7ec3cbe0ed4030f602ab3b0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Thu, 8 Oct 2026 02:04:41 -0700 Subject: [PATCH] Classify react/renderer/animated internals as private (#58882) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58882 All headers in `react/renderer/animated` were classified as "for frameworks". Most of them are implementation details of the C++ Native Animated engine: the concrete animation drivers, the concrete animated node types, and the `internal/` helpers. They are not part of the integration surface hosts use, and none of the remaining "for frameworks" headers includes them (the manager headers only forward-declare `AnimatedNode`, `AnimationDriver` and `AnimatedMountingOverrideDelegate`). This moves those 23 headers to the private tier: - `drivers/`: `AnimationDriver.h`, `AnimationDriverUtils.h`, `DecayAnimationDriver.h`, `FrameAnimationDriver.h`, `SpringAnimationDriver.h` - `internal/`: `AnimatedMountingOverrideDelegate.h`, `NativeAnimatedAllowlist.h`, `primitives.h` - `nodes/`: all concrete node types except the `AnimatedNode` base class Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123404796 --- .../react/renderer/animated/drivers/AnimationDriver.h | 2 +- .../react/renderer/animated/drivers/AnimationDriverUtils.h | 2 +- .../react/renderer/animated/drivers/DecayAnimationDriver.h | 2 +- .../react/renderer/animated/drivers/FrameAnimationDriver.h | 2 +- .../react/renderer/animated/drivers/SpringAnimationDriver.h | 2 +- .../animated/internal/AnimatedMountingOverrideDelegate.h | 2 +- .../react/renderer/animated/internal/NativeAnimatedAllowlist.h | 2 +- .../ReactCommon/react/renderer/animated/internal/primitives.h | 2 +- .../react/renderer/animated/nodes/AdditionAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/ColorAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/DiffClampAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/DivisionAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/InterpolationAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/ModulusAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/MultiplicationAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/ObjectAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/PropsAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/RoundAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/StyleAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/SubtractionAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/TrackingAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/TransformAnimatedNode.h | 2 +- .../react/renderer/animated/nodes/ValueAnimatedNode.h | 2 +- 23 files changed, 23 insertions(+), 23 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h index b3329b2c0f5b..2d20d3fc659f 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h b/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h index c96f1813820e..72cd1978c26f 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h index c3340403a50d..633f7469d276 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h index e66983365078..a0ca08e51e01 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/drivers/SpringAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animated/drivers/SpringAnimationDriver.h index bcd59857747c..bb5aaf2a6907 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/drivers/SpringAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/drivers/SpringAnimationDriver.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/internal/AnimatedMountingOverrideDelegate.h b/packages/react-native/ReactCommon/react/renderer/animated/internal/AnimatedMountingOverrideDelegate.h index c335858dbbdb..56b83c96b15c 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/internal/AnimatedMountingOverrideDelegate.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/internal/AnimatedMountingOverrideDelegate.h @@ -7,7 +7,7 @@ #pragma once -#include +#include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animated/internal/NativeAnimatedAllowlist.h b/packages/react-native/ReactCommon/react/renderer/animated/internal/NativeAnimatedAllowlist.h index f1b65c0e1a30..860c9402e900 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/internal/NativeAnimatedAllowlist.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/internal/NativeAnimatedAllowlist.h @@ -7,7 +7,7 @@ #pragma once -#include +#include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h b/packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h index ddea3d50fbdb..aadabb39e6cc 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h @@ -7,7 +7,7 @@ #pragma once -#include +#include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/AdditionAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/AdditionAnimatedNode.h index 6d90858aec28..b69d0e5753b2 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/AdditionAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/AdditionAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h index 59fae6ce1a9b..f24da69bb8dd 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/DiffClampAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/DiffClampAnimatedNode.h index 3fb464a3e624..0a2b833fb479 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/DiffClampAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/DiffClampAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/DivisionAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/DivisionAnimatedNode.h index 7964ae18b87b..65e008167926 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/DivisionAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/DivisionAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/InterpolationAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/InterpolationAnimatedNode.h index 96e8d3342144..7424984ae053 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/InterpolationAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/InterpolationAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ModulusAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ModulusAnimatedNode.h index eb05f6188692..67a3be44d4a1 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ModulusAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ModulusAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/MultiplicationAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/MultiplicationAnimatedNode.h index d8bb98df09d3..7d05a1edb48e 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/MultiplicationAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/MultiplicationAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ObjectAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ObjectAnimatedNode.h index 4d506b80a0fd..f56598bee739 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ObjectAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ObjectAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/PropsAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/PropsAnimatedNode.h index 075052b79183..fb29e431aa8a 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/PropsAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/PropsAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/RoundAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/RoundAnimatedNode.h index 40e8e78a9a6b..210eaf73e5d3 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/RoundAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/RoundAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/StyleAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/StyleAnimatedNode.h index 5aaf187c987d..1ec01dfd2209 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/StyleAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/StyleAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/SubtractionAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/SubtractionAnimatedNode.h index f60601067d26..ef74e887d3ba 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/SubtractionAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/SubtractionAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/TrackingAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/TrackingAnimatedNode.h index d7850851dfe6..16913c2e44c8 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/TrackingAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/TrackingAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/TransformAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/TransformAnimatedNode.h index b6a11144e8af..11d986f01ca5 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/TransformAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/TransformAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license. diff --git a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ValueAnimatedNode.h b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ValueAnimatedNode.h index 72f5f44222e8..6331be5810c5 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/nodes/ValueAnimatedNode.h +++ b/packages/react-native/ReactCommon/react/renderer/animated/nodes/ValueAnimatedNode.h @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -#include +#include /* * Adapted from react-native-windows under the MIT license.