Sync HAL native P/Invoke wrappers with allwpilib 2027 C exports#131
Draft
Copilot wants to merge 3 commits into
Draft
Sync HAL native P/Invoke wrappers with allwpilib 2027 C exports#131Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/robotdotnet/WPILib/sessions/b718620e-b3ab-4281-8796-d325dd56774c Co-authored-by: ThadHouse <7727148+ThadHouse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update native definitions for 2027 allwpilib exports
Sync HAL native P/Invoke wrappers with allwpilib 2027 C exports
Apr 30, 2026
Member
|
@copilot this is not correct at all. You needed to use the 2027 branch of allwpilib in the WPILibsuite organization. You grabbed from main. |
Agent-Logs-Url: https://github.com/robotdotnet/WPILib/sessions/05a53993-c1b4-47d6-9893-a6e4439c596b Co-authored-by: ThadHouse <7727148+ThadHouse@users.noreply.github.com>
Copilot stopped work on behalf of
ThadHouse due to an error
April 30, 2026 04:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several HAL native wrapper signatures have drifted from the 2027 allwpilib C headers — wrong parameter counts, incorrect
out HalStatuson void-returning frees, mistyped parameters, and missing functions.Signature Fixes
HalBaseGetSerialNumber,GetCommentsWPI_String*output viaWpiStringMarshallerHalCANAPIGetCANPacketBaseTimeHalCANHandle handleparameter (takes no args)HalCounterFreeCounterout HalStatus statusHalDIOSetDIOSimDevice[AutomateStatusCheck]decoratorHalDIOFreeDigitalPWMout HalStatus statusHalNotifierCleanNotifierout HalStatus statusHalPWMFreePWMPortout HalStatus statusHalSerialPortCloseSerialout HalStatus statusHalThreadsSetCurrentThreadPriority,SetThreadPrioritypriorityparam typebool→int(int32_tin C, notHAL_Bool)New Functions
GetCommsDisableCountSetAddressableLEDColorOrder+ newAddressableLEDColorOrderenum (RGB/RBG/BGR/BRG/GBR/GRB)GetOutputsEnabledSetDIO,PulseMultiple,SetDigitalPWMPPSSetPWMAlwaysHighMode,GetPWMConfigMicroseconds,GetPWMPulseTimeMicroseconds,SetPWMPulseTimeMicrosecondsGetCounterLoadExtensions,RegisterExtension,RegisterExtensionListener,OnShutdownWaitForMultipleInterrupts,ReleaseWaitingInterruptSetDMATimedTriggerCycles,ClearDMASensors,ClearDMAExternalTriggersResetUserCurrentFaultsGetNumCTREPCMModules,GetNumCTRESolenoidChannels,GetNumCTREPDPModules,GetNumCTREPDPChannels,GetNumREVPDHModules,GetNumREVPDHChannels,GetNumREVPHModules,GetNumREVPHChannelsSetSPIMode,GetSPIMode+ newSPIModeenum (Mode0–Mode3)GetSimDeviceName,CreateSimValueEnumDouble,ResetSimValueWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pc2vsblobprodcus360.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/ntcore.test/ntcore.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf�� get --global ndor/bin/bash HooksPath(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/hal.test/hal.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf�� get --global nfig/composer/vendor/bin/git HooksPath(dns block)pkvvsblobprodcus321.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/codehelp/CodeHelpers.Test/CodeHelpers.Test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf��(dns block)vb4vsblobprodcus33.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/wpimath.test/wpimath.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true src/�� get HalSerialPort.cs ndor/bin/bash core.hooksPath(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/datalog.test/datalog.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf�� get HalCANAPI.cs cal/bin/git core.hooksPath(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/wpilibsharp.test/wpilibsharp.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true src/�� get HalNotifier.cs t core.hooksPath(dns block)wpilib.jfrog.io/usr/bin/dotnet dotnet build src/hal/hal.csproj(dns block)/usr/bin/dotnet dotnet build src/hal/hal.csproj --no-restore -v quiet(dns block)/opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp(dns block)x3yvsblobprodcus370.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/wpimath.test/wpimath.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true src/�� get HalSerialPort.cs ndor/bin/bash core.hooksPath(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/ntcore.test/ntcore.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf�� get --global ndor/bin/bash HooksPath(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WPILib/WPILib/test/wpinet.test/wpinet.test.csproj --packages /tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-47362ed0795ee60f/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true conf�� --global ent-Logs-Url: REDACTED e/git-remote-https(dns block)If you need me to access, download, or install something from one of these locations, you can either: