dist(release/1.29): backport patches#4867
Draft
rami3l wants to merge 37 commits into
Draft
Conversation
PartialTargetTriple::is_empty()
rami3l
added
the
backport
This alias was originally added in 7e1eeb9. This applies that same alias to all places where -y is used to suppress a confirmation prompt. Specifically, that includes rustup-init, the downloader script and `rustup self uninstall`.
Member
Author
|
Well, there ARE some rough edges but should be pretty simple to resolve, I'll find some time to look at them later... At least there has been 0 conflicts during the rebase which is quite impressive in itself already :o |
…g "unchanged" When the v2 channel manifest's `.toml` did not match its published `.sha256`, `try_update_from_dist_` mapped `RustupError::ChecksumFailed` to `Ok(None)`. Callers interpret `Ok(None)` as "no update available", so `rustup update` printed only a `warn:` line, reported the toolchain as `unchanged`, and exited 0, even though the manifest could not be integrity-checked.
…_RECURSION_COUNT` This commit clears the value of `RUSTUP_AUTO_INSTALL` and the `RUST_RECURSION_COUNT` environment variables before running tests, to make sure that every test case relying on their effects is explicitly setting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is an experimentation of how backporting could possibly work. Don't merge yet.
@djc wow, with atomic commits, backporting is as simple as dropping the incompatible commits? I'm impressed...