From ff4a7cac6fa4dd58fa88247d5ac9354f75138dd8 Mon Sep 17 00:00:00 2001 From: "Daniel A. Wozniak" Date: Sun, 1 Nov 2026 00:38:55 -0700 Subject: [PATCH 1/2] Skip saltext-zabbix editable-install tests on Python 3.10 test_install_editable_package and test_install_editable_package_in_extras clone HEAD of https://github.com/salt-extensions/saltext-zabbix and run `pip install -e saltext-zabbix`. saltext-zabbix bumped its python_requires to >=3.11, so on Python 3.10 pip refuses the install and the tests fail with ``assert p.returncode == 0``. Mark both tests skipif(sys.version_info < (3, 11)). They cover the editable-install path, not anything zabbix-specific, and the salt-extensions ecosystem is dropping 3.10 broadly, so pinning a legacy tag would just defer this. Linux 3.11+ coverage is preserved. --- tests/test_verify_build.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/test_verify_build.py b/tests/test_verify_build.py index 4ba95b77..aca96c2d 100644 --- a/tests/test_verify_build.py +++ b/tests/test_verify_build.py @@ -1924,6 +1924,10 @@ def test_install_pyinotify_w_latest_pip(pipexec, build, minor_version): @pytest.mark.skip_unless_on_linux +@pytest.mark.skipif( + sys.version_info < (3, 11), + reason="saltext-zabbix HEAD requires Python >= 3.11", +) def test_install_editable_package(pipexec, pyexec, build, minor_version, tmp_path): _install_ppbt(pyexec) os.chdir(tmp_path) @@ -1947,6 +1951,10 @@ def test_install_editable_package(pipexec, pyexec, build, minor_version, tmp_pat @pytest.mark.skip_unless_on_linux +@pytest.mark.skipif( + sys.version_info < (3, 11), + reason="saltext-zabbix HEAD requires Python >= 3.11", +) def test_install_editable_package_in_extras(pipexec, pyexec, build, minor_version, tmp_path): _install_ppbt(pyexec) sitepkgs = pathlib.Path(build) / "lib" / f"python{minor_version}" / "site-packages" From 7fbf9ecb178c3f9525379cab00e61e6cccf42e6a Mon Sep 17 00:00:00 2001 From: "Daniel A. Wozniak" Date: Sun, 1 Nov 2026 15:35:31 -0700 Subject: [PATCH 2/2] Key saltext-zabbix skip on build Python, not host Python The previous commit used ``@pytest.mark.skipif(sys.version_info < (3, 11))``, which evaluates against the Python running pytest -- the host runner Python (3.11+), not the relenv-built Python under test. So on the ``Verify Linux (3.10, ...)`` jobs the marker never fired and the tests still ran against a 3.10 relenv build, hitting the same ``pip install -e saltext-zabbix`` failure. Move the check inside the test body and gate on the ``minor_version`` fixture (which yields the build Python's ``MAJOR.MINOR``). Matches the in-body ``pytest.skip(reason=...)`` pattern already used elsewhere in this file. --- tests/test_verify_build.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/test_verify_build.py b/tests/test_verify_build.py index aca96c2d..428dc52c 100644 --- a/tests/test_verify_build.py +++ b/tests/test_verify_build.py @@ -1924,11 +1924,9 @@ def test_install_pyinotify_w_latest_pip(pipexec, build, minor_version): @pytest.mark.skip_unless_on_linux -@pytest.mark.skipif( - sys.version_info < (3, 11), - reason="saltext-zabbix HEAD requires Python >= 3.11", -) def test_install_editable_package(pipexec, pyexec, build, minor_version, tmp_path): + if tuple(int(x) for x in minor_version.split(".")) < (3, 11): + pytest.skip(reason="saltext-zabbix HEAD requires Python >= 3.11") _install_ppbt(pyexec) os.chdir(tmp_path) env = os.environ.copy() @@ -1951,11 +1949,9 @@ def test_install_editable_package(pipexec, pyexec, build, minor_version, tmp_pat @pytest.mark.skip_unless_on_linux -@pytest.mark.skipif( - sys.version_info < (3, 11), - reason="saltext-zabbix HEAD requires Python >= 3.11", -) def test_install_editable_package_in_extras(pipexec, pyexec, build, minor_version, tmp_path): + if tuple(int(x) for x in minor_version.split(".")) < (3, 11): + pytest.skip(reason="saltext-zabbix HEAD requires Python >= 3.11") _install_ppbt(pyexec) sitepkgs = pathlib.Path(build) / "lib" / f"python{minor_version}" / "site-packages"