Skip to content

Commit f1328dc

Browse files
committed
feat(pencil): added 'phone' option to event
1 parent b0ddf52 commit f1328dc

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/api-manager.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ const sdkEvent: EventOptions = {
2727
userTraits: {
2828
name: 'USER_NAME',
2929
email: 'USER_EMAIL',
30+
phone: '+123456789',
3031
},
3132
context: {
3233
ip: '127.0.0.1',
@@ -76,6 +77,7 @@ describe('ApiManager', () => {
7677
expect(eventPayload).to.have.property('userTraits');
7778
expect(eventPayload.userTraits).to.have.property('name', sdkEvent.userTraits.name);
7879
expect(eventPayload.userTraits).to.have.property('email', sdkEvent.userTraits.email);
80+
expect(eventPayload.userTraits).to.have.property('phone', sdkEvent.userTraits.phone);
7981
//properties
8082

8183
expect(eventPayload).to.have.property('properties');
@@ -220,6 +222,7 @@ describe('ApiManager', () => {
220222
expect(eventPayload).to.have.property('userId', sdkEvent.userId);
221223
expect(eventPayload.userTraits).to.have.property('name', sdkEvent.userTraits.name);
222224
expect(eventPayload.userTraits).to.have.property('email', sdkEvent.userTraits.email);
225+
expect(eventPayload.userTraits).to.have.property('phone', sdkEvent.userTraits.phone);
223226
//properties
224227
expect(eventPayload).to.have.property('properties');
225228
expect(Object.keys(eventPayload.properties)).to.have.lengthOf(Object.keys(sdkEvent.properties).length, 'Incorrect number of custom properties');

src/events/sdk-event.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export default class SDKEvent implements IEvent {
1515
public userTraits: {
1616
name: string;
1717
email: string;
18+
phone: string;
1819
createdAt: string;
1920
};
2021
public request: {
@@ -51,6 +52,7 @@ export default class SDKEvent implements IEvent {
5152
this.userTraits = {
5253
name: user.name || '',
5354
email: user.email || '',
55+
phone: user.phone || '',
5456
createdAt: user.createdAt?.toISOString() || new Date(0).toISOString(),
5557
};
5658
this.request = {

src/types/event-options.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import EventType from '../enums/event-type';
2-
import { IncomingHttpHeaders } from 'http2';
3-
import { CustomProperties } from './custom-properties';
1+
import EventType from "../enums/event-type";
2+
import { IncomingHttpHeaders } from "http2";
3+
import { CustomProperties } from "./custom-properties";
44

55
export type Context = {
66
clientToken?: string;
@@ -15,6 +15,7 @@ export type EventOptions = {
1515
userTraits?: {
1616
name?: string;
1717
email?: string;
18+
phone?: string;
1819
createdAt?: Date;
1920
};
2021
context?: Context;

0 commit comments

Comments
 (0)