Camera model - SQL schema issue with on column

[rokf]

Hello,

The SQL schema for the Camera model seems to have a bug where the on column isn't quoted. on is a keyword and should therefore be written as "on" to be accepted by PostgreSQL.

https://github.com/smart-data-models/dataModel.Device/blob/master/Camera/schema.sql

The same is true for DuckDB - it uses PostgreSQL's syntax and complains about the same issue when I try to execute the the schema file.

In case that these schema files are generated it might make sense to adjust the code of the generator so that it quotes all the columns to avoid such issues? There are plenty of keywords in PostgreSQL/DuckDB which could cause the same problem 🤔

Thank you!

[albertoabellagarcia]

There are several issues like this (AS) meaning arsenic, and 'on'.

[rokf]

The SQL schema generator that is used to produce these schema.sql files is the one at https://github.com/smart-data-models/data-models/blob/master/pysmartdatamodels/pysmartdatamodels/pysmartdatamodels.py#L1131, correct?

Edit: I've now opened an issue in that repository - smart-data-models/data-models#73.